doc,crypto: clarify oaepHash option's impact #32340
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
crypto
jasnell
approved these changes
Mar 18, 2020
panva
force-pushed
the
crypto-docs-update
branch
from
2ddc5e5
to
88db298
Compare
panva
force-pushed
the
crypto-docs-update
branch
from
88db298
to
d823572
Compare
tniessen
approved these changes
Mar 21, 2020
|
Can't do much about the failing CI, it seems to be just timeouts... over a doc update? |
|
Restarted. |
addaleax
added
the
author ready
|
Landed in 154d4e5 |
addaleax
pushed a commit
that referenced
this pull request
Mar 29, 2020
PR-URL: #32340 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
addaleax
pushed a commit
that referenced
this pull request
Mar 30, 2020
PR-URL: #32340 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
targos
pushed a commit
that referenced
this pull request
Apr 22, 2020
PR-URL: #32340 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduced in #28335 this option also applies the hash function to MGF1, not just OAEP. This doc update makes that clear.