util: only inspect error properties that are not visible otherwise #32327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Inspecting errors results in duplicated information in case an error is created with enumerable `name`, `message` or `stack` properties. In that case, check if the output already contains that information and prevent listing that property. This reduces the noise as receiver.
nodejs-github-bot
added
the
util
|
@nodejs/util PTAL |
antsmartian
approved these changes
Mar 19, 2020
addaleax
added
the
author ready
|
CI: https://ci.nodejs.org/job/node-test-pull-request/30256/ (:heavy_check_mark:) |
addaleax
pushed a commit
that referenced
this pull request
Apr 2, 2020
Inspecting errors results in duplicated information in case an error is created with enumerable `name`, `message` or `stack` properties. In that case, check if the output already contains that information and prevent listing that property. This reduces the noise as receiver. PR-URL: #32327 Reviewed-By: Anto Aravinth <[email protected]>
|
Landed in 6baddcf |
BethGriggs
pushed a commit
that referenced
this pull request
Apr 7, 2020
Inspecting errors results in duplicated information in case an error is created with enumerable `name`, `message` or `stack` properties. In that case, check if the output already contains that information and prevent listing that property. This reduces the noise as receiver. PR-URL: #32327 Reviewed-By: Anto Aravinth <[email protected]>
targos
pushed a commit
that referenced
this pull request
Apr 12, 2020
Inspecting errors results in duplicated information in case an error is created with enumerable `name`, `message` or `stack` properties. In that case, check if the output already contains that information and prevent listing that property. This reduces the noise as receiver. PR-URL: #32327 Reviewed-By: Anto Aravinth <[email protected]>
targos
pushed a commit
that referenced
this pull request
Apr 22, 2020
Inspecting errors results in duplicated information in case an error is created with enumerable `name`, `message` or `stack` properties. In that case, check if the output already contains that information and prevent listing that property. This reduces the noise as receiver. PR-URL: #32327 Reviewed-By: Anto Aravinth <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inspecting errors results in duplicated information in case an error
is created with enumerable
name,messageorstackproperties.In that case, check if the output already contains that information
and prevent listing that property.
This reduces the noise as receiver.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes