Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps: update acorn to v7.1.1 #32310

Closed
wants to merge 1 commit into from
Closed

deps: update acorn to v7.1.1 #32310

wants to merge 1 commit into from

Conversation

BridgeAR
Copy link
Member

@BridgeAR BridgeAR commented Mar 17, 2020 •
edited
Loading

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@BridgeAR BridgeAR force-pushed the 2020-03-17-update-acorn-deps branch from c745361 to 911a5ae Compare March 17, 2020 01:51
@BridgeAR
deps: update acorn to v7.1.1
6c17b42 
Also clean up the plugins package.json files.
@BridgeAR BridgeAR force-pushed the 2020-03-17-update-acorn-deps branch from 911a5ae to 6c17b42 Compare March 17, 2020 02:10
Trott
Trott approved these changes Mar 17, 2020
View reviewed changes
Copy link
Member

@Trott Trott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rubber stamp LGTM

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/29882/

@sam-github sam-github mentioned this pull request Mar 17, 2020
Closed
4 tasks
@BridgeAR BridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 17, 2020
trivikr
trivikr approved these changes Mar 18, 2020
View reviewed changes
Copy link
Member

@trivikr trivikr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/30089/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/30125/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Mar 27, 2020 •
edited by addaleax
Loading

CI: https://ci.nodejs.org/job/node-test-pull-request/30138/ (:heavy_check_mark:)

@addaleax
Copy link
Member

Landed in 08c656b

addaleax pushed a commit that referenced this pull request Mar 29, 2020
@BridgeAR @addaleax
deps: update acorn to v7.1.1
08c656b 
Also clean up the plugins package.json files.

PR-URL: #32310
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
@addaleax addaleax closed this Mar 29, 2020
addaleax pushed a commit that referenced this pull request Mar 30, 2020
@BridgeAR @addaleax
deps: update acorn to v7.1.1
f690fc9 
Also clean up the plugins package.json files.

PR-URL: #32310
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
@targos targos mentioned this pull request Apr 13, 2020
Merged
targos pushed a commit that referenced this pull request Apr 22, 2020
@BridgeAR @targos
deps: update acorn to v7.1.1
fedcb16 
Also clean up the plugins package.json files.

PR-URL: #32310
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
@targos targos mentioned this pull request Apr 22, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trivikr trivikr trivikr approved these changes

@gengjiawen gengjiawen gengjiawen approved these changes

@Trott Trott Trott approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@BridgeAR @nodejs-github-bot @addaleax @jasnell @Trott @gengjiawen @trivikr