Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: use uppercase on windows path #32294

Closed
wants to merge 1 commit into from
Closed

doc: use uppercase on windows path #32294

wants to merge 1 commit into from

Conversation

himself65
Copy link
Member

Checklist

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Mar 16, 2020
bzoz
bzoz approved these changes Mar 16, 2020
View reviewed changes
Copy link
Contributor

@bzoz bzoz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Looks like we are using C: everywhere else in those docs.

@himself65 himself65 mentioned this pull request Mar 17, 2020
Closed
2 tasks
ExE-Boss
ExE-Boss approved these changes Mar 18, 2020
View reviewed changes
Copy link
Contributor

@ExE-Boss ExE-Boss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do note that: “https://docs.microsoft.com/windows/desktop/FileIO/naming-a-file#fully-qualified-vs-relative-paths” has moved to: “https://docs.microsoft.com/windows/win32/fileio/naming-a-file#fully-qualified-vs-relative-paths”.

@himself65
Copy link
Member Author

Do note that: “https://docs.microsoft.com/windows/desktop/FileIO/naming-a-file#fully-qualified-vs-relative-paths” has moved to: “https://docs.microsoft.com/windows/win32/fileio/naming-a-file#fully-qualified-vs-relative-paths”.

This not the responsibility of this PR. I think

@jasnell
Copy link
Member

jasnell commented Mar 18, 2020

This not the responsibility of this PR. I think

While true, it wouldn't hurt to go ahead and update here.

@addaleax addaleax added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 29, 2020
@addaleax
Copy link
Member

Landed in cc8066e

@addaleax addaleax closed this Mar 29, 2020
addaleax pushed a commit that referenced this pull request Mar 29, 2020
@himself65 @addaleax
doc: use uppercase on windows path
cc8066e 
PR-URL: #32294
Reviewed-By: Bartosz Sosnowski <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
addaleax pushed a commit that referenced this pull request Mar 30, 2020
@himself65 @addaleax
doc: use uppercase on windows path
e7e3aee 
PR-URL: #32294
Reviewed-By: Bartosz Sosnowski <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
@targos targos mentioned this pull request Apr 13, 2020
Merged
targos pushed a commit that referenced this pull request Apr 22, 2020
@himself65 @targos
doc: use uppercase on windows path
59a8dbe 
PR-URL: #32294
Reviewed-By: Bartosz Sosnowski <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
@targos targos mentioned this pull request Apr 22, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@addaleax addaleax addaleax approved these changes

@lpinca lpinca lpinca approved these changes

@ExE-Boss ExE-Boss ExE-Boss approved these changes

@trivikr trivikr trivikr approved these changes

@bzoz bzoz bzoz approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@himself65 @jasnell @addaleax @lpinca @ExE-Boss @trivikr @bzoz @nodejs-github-bot