Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: fix typos in docs #32292

Closed
wants to merge 3 commits into from
Closed

chore: fix typos in docs #32292

wants to merge 3 commits into from

Conversation

snitin315
Copy link
Contributor

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

addaleax
addaleax requested changes Mar 29, 2020
View reviewed changes
Copy link
Member

@addaleax addaleax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be great if the changes to test/cctest/gtest and test/fixtures/wpt/resources could be undone/upstreamed.

I’ll mark this as request-changes so it doesn’t accidentally land until that has been addressed, but otherwise it looks good to me.

Trott
Trott approved these changes Mar 30, 2020
View reviewed changes
Copy link
Member

@Trott Trott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree with @addaleax and others that some of these should be left alone and done upstream. Would even go further and suggest that the fixes can all be separate commits to easy backporting. But I'm OK with it as one commit too.

@snitin315
Copy link
Contributor Author

@Trott @addaleax Done.

@snitin315 snitin315 changed the title chore: fix typos chore: fix typos in docs Mar 30, 2020
@addaleax addaleax added the doc Issues and PRs related to the documentations. label Mar 30, 2020
@addaleax
Copy link
Member

Landed in 67d5c90...575b4e3, thanks for the PR!

@addaleax addaleax closed this Mar 30, 2020
addaleax pushed a commit that referenced this pull request Mar 30, 2020
@snitin315 @addaleax
doc: fix typo in maintaining-openssl guide
be2f36a 
PR-URL: #32292
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
addaleax pushed a commit that referenced this pull request Mar 30, 2020
@snitin315 @addaleax
doc: fix typo in maintaining-zlib guide
988f5bf 
PR-URL: #32292
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
addaleax pushed a commit that referenced this pull request Mar 30, 2020
@snitin315 @addaleax
doc: fix typo in http2 docs
575b4e3 
PR-URL: #32292
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
addaleax pushed a commit that referenced this pull request Mar 30, 2020
@snitin315 @addaleax
doc: fix typo in maintaining-openssl guide
6cdccc8 
PR-URL: #32292
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
addaleax pushed a commit that referenced this pull request Mar 30, 2020
@snitin315 @addaleax
doc: fix typo in maintaining-zlib guide
02b0c9e 
PR-URL: #32292
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
addaleax pushed a commit that referenced this pull request Mar 30, 2020
@snitin315 @addaleax
doc: fix typo in http2 docs
002048e 
PR-URL: #32292
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
@targos targos mentioned this pull request Apr 13, 2020
Merged
targos pushed a commit to targos/node that referenced this pull request Apr 25, 2020
@snitin315 @targos
doc: fix typo in maintaining-zlib guide
372a8f2 
PR-URL: nodejs#32292
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
targos pushed a commit to targos/node that referenced this pull request Apr 25, 2020
@snitin315 @targos
doc: fix typo in maintaining-openssl guide
6bde76d 
PR-URL: nodejs#32292
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
targos pushed a commit that referenced this pull request Apr 28, 2020
@snitin315 @targos
doc: fix typo in maintaining-zlib guide
f13ecd8 
PR-URL: #32292
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
targos pushed a commit that referenced this pull request Apr 28, 2020
@snitin315 @targos
doc: fix typo in maintaining-openssl guide
13342f8 
PR-URL: #32292
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
@targos targos mentioned this pull request May 2, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lpinca lpinca lpinca left review comments

@mmarchini mmarchini mmarchini left review comments

@Trott Trott Trott approved these changes

@addaleax addaleax addaleax approved these changes

@cjihrig cjihrig cjihrig approved these changes

@shivaylamba shivaylamba shivaylamba approved these changes

@trivikr trivikr Awaiting requested review from trivikr

@jasnell jasnell Awaiting requested review from jasnell

Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@snitin315 @addaleax @jasnell @Trott @lpinca @cjihrig @mmarchini @trivikr @shivaylamba @targos