http: don't emit 'finish' after 'error' #32276
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
http
ronag
force-pushed
the
http-error-finish
branch
from
ace1aec
to
c67b545
Compare
jasnell
approved these changes
Mar 16, 2020
ronag
added
the
author ready
trivikr
approved these changes
Mar 18, 2020
|
Landed in a9270dc |
ronag
added a commit
that referenced
this pull request
Mar 18, 2020
PR-URL: #32276 Refs: #28710 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Mar 19, 2020
PR-URL: #32276 Refs: #28710 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Mar 24, 2020
PR-URL: #32276 Refs: #28710 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
|
is this safe to land on v12 ? |
|
@targos: I think so. |
targos
pushed a commit
that referenced
this pull request
Apr 22, 2020
PR-URL: #32276 Refs: #28710 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An edge case could emit
'finish'after'error'.Refs: #28710
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes