macOS notarization 13.x backport #32243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Includes hardened-runtime patch from gdams from nodejs#29216 (comment) PR-URL: nodejs#31459 Refs: nodejs#29216 Reviewed-By: Christian Clauss <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Ash Cripps <[email protected]> Signed-off-by: Rod Vagg <[email protected]>
PR-URL: nodejs#31459 Refs: nodejs#29216 Refs: sindresorhus/macos-terminal-size#3 Reviewed-By: Christian Clauss <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Ash Cripps <[email protected]> Signed-off-by: Rod Vagg <[email protected]>
PR-URL: nodejs#31459 Refs: nodejs#29216 Reviewed-By: Christian Clauss <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Ash Cripps <[email protected]> Signed-off-by: Rod Vagg <[email protected]>
nodejs-github-bot
added
build
4 tasks
AshCripps
approved these changes
Mar 13, 2020
|
merged into 13.x-staging, nodejs/build#2202 is merged too so 🤞 it all should be ready to build the next 13.x |
|
https://nodejs.org/download/nightly/v13.11.1-nightly2020031763bf0f134c/ 13.x nightly with notarization working |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@nodejs/build @nodejs/releasers
As mentioned in #31459 (comment) this needs to be synchronized with nodejs/build#2202 so we get the right builder in place. Nightlies are being signed as of today, it'd be good to let them into the wild for a few days at least before landing this.
For the 13.x release that this lands in, we should include an item in the Notable Items list about the change of builder since we're breaking our contract of keeping build configurations stable for the life of a release line. Here's my proposal, suggestions for changes welcome:
@BridgeAR if nodejs/Release#487 is correct then you're up next and it's due next week? Take note.
We'll need to repeat this with 12.x and 10.x builds (we'll need to clarify which version of macOS & which Xcode are currently being used for each of those, however).