Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: update AUTHORS list #32222

Closed
wants to merge 1 commit into from
Closed

doc: update AUTHORS list #32222

wants to merge 1 commit into from

Conversation

lpinca
Copy link
Member

@lpinca lpinca commented Mar 12, 2020

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the meta Issues and PRs related to the general management of the project. label Mar 12, 2020
@lpinca
Copy link
Member Author

lpinca commented Mar 12, 2020 •
edited
Loading

  • Alex Zherdev
  • Eric Bickle
  • Maël Nison
  • Sergey Zelenov
  • Tim Costa

Could be duplicates.

@lpinca
Copy link
Member Author

lpinca commented Mar 26, 2020

@nodejs/collaborators

@andrewhughes101
Copy link
Contributor

andrewhughes101 commented Mar 26, 2020 •
edited
Loading

@lpinca Mines (Andrew Hughes) a duplicate

@lpinca
Copy link
Member Author

lpinca commented Mar 26, 2020

@andrewhughes101 thank you, fixed.

@addaleax addaleax added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 29, 2020
@addaleax
Copy link
Member

addaleax commented Mar 30, 2020 •
edited
Loading

Landed in a4106a71592532e7ca051f053f5f071292920197 bbf3fb8

@addaleax addaleax closed this Mar 30, 2020
addaleax pushed a commit that referenced this pull request Mar 30, 2020
@lpinca @addaleax
doc: update AUTHORS list
bbf3fb8 
PR-URL: #32222
Reviewed-By: Anna Henningsen <[email protected]>
@lpinca lpinca deleted the update/authors branch March 30, 2020 15:28
addaleax pushed a commit that referenced this pull request Mar 30, 2020
@lpinca @addaleax
doc: update AUTHORS list
b494053 
PR-URL: #32222
Reviewed-By: Anna Henningsen <[email protected]>
@targos targos mentioned this pull request Apr 13, 2020
Merged
targos pushed a commit that referenced this pull request Apr 22, 2020
@lpinca @targos
doc: update AUTHORS list
d0d414d 
PR-URL: #32222
Reviewed-By: Anna Henningsen <[email protected]>
@targos targos mentioned this pull request Apr 22, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@addaleax addaleax addaleax approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. meta Issues and PRs related to the general management of the project.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lpinca @andrewhughes101 @addaleax @nodejs-github-bot