stream: avoid destroying http1 objects #32197
Conversation
|
I'm sorry about 8a2b62e causing these troubles. I've tried to resolve these follow up issues as quickly as possible. |
|
@ronag are we sure we should not revert all of those fixes instead and redo a PR with all of them? |
I would prefer not. Seems more difficult than fixing it. I see your point though. If you would prefer revert I would be ok with that. |
|
Let's see if something else pop up. |
ronag
force-pushed
the
pipeline-fix-destroyer
branch
2 times, most recently
from
5aeab8d to
abd091c
Compare
ronag
added
the
author ready
MylesBorins
added
the
fast-track
|
can we fast track this? I'd like to see it land in the upcoming 13.11.0 release @ronag looks like this needs a rebase |
http1 objects are coupled with their corresponding res/req and cannot be treated independently as normal streams. Add a special exception for this in the pipeline cleanup. Fixes: nodejs#32184
ronag
force-pushed
the
pipeline-fix-destroyer
branch
from
d83675f to
1415464
Compare
|
rebased @MylesBorins |
|
+1 to fast track |
|
@ronag FWIW this patch is not going to land cleanly on v13.x. You might want to get started on a backport now if you have time. very much trying to get this out in today's release. |
|
landed in f8f2089 |
http1 objects are coupled with their corresponding res/req and cannot be treated independently as normal streams. Add a special exception for this in the pipeline cleanup. Fixes: #32184 PR-URL: #32197 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Matteo Collina <[email protected]>
http1 objects are coupled with their corresponding res/req and cannot be treated independently as normal streams. Add a special exception for this in the pipeline cleanup. Fixes: #32184 Backport-PR-URL: #32212 PR-URL: #32197 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Matteo Collina <[email protected]>
http1 objects are coupled with their corresponding
res/req and cannot be treated independently as
normal streams. Add a special exception for this
in the pipeline cleanup.
Fixes: #32184
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes