Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: remove personal pronouns in reference docs prose #32142

Closed
wants to merge 0 commits into from

Conversation

Trott
Copy link
Member

@Trott Trott commented Mar 8, 2020

Per style guide, avoid personal pronouns in reference docs, hopefully without introducing a ton of passive voice.

Lint rule is possible, but I personally want to take some time to make sure this isn't a guideline we want to keep. For now, though, abide by it.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Mar 8, 2020
@Trott Trott changed the title doc: remove personal pronouns doc: remove personal pronouns in reference docs prose Mar 8, 2020
@BridgeAR BridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 9, 2020
@Trott
Copy link
Member Author

Trott commented Mar 10, 2020

Landed in 66e32ff...73f2dbc

Trott added a commit to Trott/io.js that referenced this pull request Mar 10, 2020
Per our style guide, avoid personal pronouns (I, you, we, etc.) in
reference documentation.

PR-URL: nodejs#32142
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Trott added a commit to Trott/io.js that referenced this pull request Mar 10, 2020
Per our style guide, avoid personal pronouns (I, you, we, etc.) in
reference documentation.

PR-URL: nodejs#32142
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Trott added a commit to Trott/io.js that referenced this pull request Mar 10, 2020
Per our style guide, avoid personal pronouns (I, you, we, etc.) in
reference documentation.

PR-URL: nodejs#32142
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Trott added a commit to Trott/io.js that referenced this pull request Mar 10, 2020
Per our style guide, avoid personal pronouns (I, you, we, etc.) in
reference documentation.

PR-URL: nodejs#32142
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
@Trott Trott closed this Mar 10, 2020
@Trott Trott deleted the de-you branch March 10, 2020 02:48
MylesBorins pushed a commit that referenced this pull request Mar 10, 2020
Per our style guide, avoid personal pronouns (I, you, we, etc.) in
reference documentation.

PR-URL: #32142
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
MylesBorins pushed a commit that referenced this pull request Mar 10, 2020
Per our style guide, avoid personal pronouns (I, you, we, etc.) in
reference documentation.

PR-URL: #32142
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
MylesBorins pushed a commit that referenced this pull request Mar 10, 2020
Per our style guide, avoid personal pronouns (I, you, we, etc.) in
reference documentation.

PR-URL: #32142
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
MylesBorins pushed a commit that referenced this pull request Mar 10, 2020
Per our style guide, avoid personal pronouns (I, you, we, etc.) in
reference documentation.

PR-URL: #32142
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Mar 10, 2020
@targos targos added backport-blocked-v12.x and removed author ready PRs that have at least one approval, no pending requests for changes, and a CI started. backport-blocked-v12.x labels Apr 20, 2020
targos pushed a commit to targos/node that referenced this pull request Apr 25, 2020
Per our style guide, avoid personal pronouns (I, you, we, etc.) in
reference documentation.

PR-URL: nodejs#32142
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
targos pushed a commit to targos/node that referenced this pull request Apr 25, 2020
Per our style guide, avoid personal pronouns (I, you, we, etc.) in
reference documentation.

PR-URL: nodejs#32142
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
targos pushed a commit to targos/node that referenced this pull request Apr 25, 2020
Per our style guide, avoid personal pronouns (I, you, we, etc.) in
reference documentation.

PR-URL: nodejs#32142
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
targos pushed a commit to targos/node that referenced this pull request Apr 25, 2020
Per our style guide, avoid personal pronouns (I, you, we, etc.) in
reference documentation.

PR-URL: nodejs#32142
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
targos pushed a commit that referenced this pull request Apr 28, 2020
Per our style guide, avoid personal pronouns (I, you, we, etc.) in
reference documentation.

PR-URL: #32142
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
targos pushed a commit that referenced this pull request Apr 28, 2020
Per our style guide, avoid personal pronouns (I, you, we, etc.) in
reference documentation.

PR-URL: #32142
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
targos pushed a commit that referenced this pull request Apr 28, 2020
Per our style guide, avoid personal pronouns (I, you, we, etc.) in
reference documentation.

PR-URL: #32142
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
targos pushed a commit that referenced this pull request Apr 28, 2020
Per our style guide, avoid personal pronouns (I, you, we, etc.) in
reference documentation.

PR-URL: #32142
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Issues and PRs related to the documentations.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants