Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

stream: add comments to pipeline implementation #32042

Closed
wants to merge 1 commit into from
Closed

stream: add comments to pipeline implementation #32042

wants to merge 1 commit into from

Conversation

ronag
Copy link
Member

@ronag ronag commented Mar 2, 2020

Fixes: #32039

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@ronag ronag requested a review from mcollina March 2, 2020 11:46
@ronag ronag added the stream Issues and PRs related to the stream subsystem. label Mar 2, 2020
@ronag ronag force-pushed the pipeline-comments branch 2 times, most recently from d73d067 to 62aa7d4 Compare March 2, 2020 11:46
mcollina
mcollina approved these changes Mar 2, 2020
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ronag ronag added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 3, 2020
@ronag
Copy link
Member Author

ronag commented Mar 7, 2020

Landed in 960be15

@ronag ronag closed this Mar 7, 2020
ronag added a commit that referenced this pull request Mar 7, 2020
@ronag
stream: add comments to pipeline implementation
960be15 
Fixes: #32039

PR-URL: #32042
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: James M Snell <[email protected]>
MylesBorins pushed a commit that referenced this pull request Mar 9, 2020
@ronag @MylesBorins
stream: add comments to pipeline implementation
2585b81 
Fixes: #32039

PR-URL: #32042
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Mar 10, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@addaleax addaleax addaleax approved these changes

@jasnell jasnell jasnell approved these changes

@mcollina mcollina mcollina approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. stream Issues and PRs related to the stream subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Avoid PassThrough to avoid buffering in pipeline
5 participants
@ronag @mcollina @jasnell @addaleax @targos