Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: update email address in authors #32026

Closed
wants to merge 1 commit into from
Closed

doc: update email address in authors #32026

wants to merge 1 commit into from

Conversation

yaelhe
Copy link
Contributor

@yaelhe yaelhe commented Feb 29, 2020

updated my email address

Checklist

@yaelhe
doc: update email address in authors
be142b3 
update my personal email
@nodejs-github-bot nodejs-github-bot added the meta Issues and PRs related to the general management of the project. label Feb 29, 2020
@Trott Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Feb 29, 2020
mhdawson
mhdawson reviewed Mar 2, 2020
View reviewed changes
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mhdawson
Copy link
Member

mhdawson commented Mar 2, 2020

git-node land tells me it still needs 19 hours to land. Believe this could be fast tracked.

@mhdawson mhdawson added the fast-track PRs that do not need to wait for 48 hours to land. label Mar 2, 2020
jasnell pushed a commit that referenced this pull request Mar 5, 2020
@yaelhe @jasnell
doc: update email address in authors
0d8a84a 
update my personal email

PR-URL: #32026
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Matheus Marchini <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@jasnell
Copy link
Member

jasnell commented Mar 5, 2020

Landed in 0d8a84a

@jasnell jasnell closed this Mar 5, 2020
@yaelhe yaelhe deleted the email branch March 8, 2020 02:36
MylesBorins pushed a commit that referenced this pull request Mar 9, 2020
@yaelhe @MylesBorins
doc: update email address in authors
5f12595 
update my personal email

PR-URL: #32026
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Matheus Marchini <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Mar 10, 2020
Merged
codebytere pushed a commit that referenced this pull request Mar 16, 2020
@yaelhe @codebytere
doc: update email address in authors
5d8ea68 
update my personal email

PR-URL: #32026
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Matheus Marchini <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
codebytere pushed a commit that referenced this pull request Mar 17, 2020
@yaelhe @codebytere
doc: update email address in authors
72d52c7 
update my personal email

PR-URL: #32026
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Matheus Marchini <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@codebytere codebytere mentioned this pull request Mar 17, 2020
Merged
codebytere pushed a commit that referenced this pull request Mar 23, 2020
@yaelhe @codebytere
doc: update email address in authors
4254763 
update my personal email

PR-URL: #32026
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Matheus Marchini <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
codebytere pushed a commit that referenced this pull request Mar 30, 2020
@yaelhe @codebytere
doc: update email address in authors
047bd9d 
update my personal email

PR-URL: #32026
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Matheus Marchini <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Trott Trott Trott approved these changes

@addaleax addaleax addaleax approved these changes

@lpinca lpinca lpinca approved these changes

@targos targos targos approved these changes

@mmarchini mmarchini mmarchini approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

@mhdawson mhdawson mhdawson approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. fast-track PRs that do not need to wait for 48 hours to land. meta Issues and PRs related to the general management of the project.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@yaelhe @mhdawson @jasnell @Trott @addaleax @lpinca @targos @mmarchini @BridgeAR @nodejs-github-bot