repl: allow recovery for wrapped eval #31990
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is this actually necessary? The code is first checked as wrapped code and in case that fails it is run unwrapped. |
|
Hmm looks like you're right - I was proceeding on the assumption it was based on the original issue but i think that was just my misreading! Closing :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #31943.
In the PR above, repl eval was altered to eagerly try and wrap code with parens, but this could in some cases cause failures for code which is only valid JavaScript in an unwrapped state.
This PR makes that logic more robust by ensuring that the wrapped code is parsed to be valid JS before evaluation continues, and proceeds unwrapped if it is found to be invalid.
cc @devsnek @BridgeAR
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes