Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

meta: move not-an-aardvark to emeritus #31928

Merged
merged 1 commit into from
Feb 26, 2020
Merged

meta: move not-an-aardvark to emeritus #31928

merged 1 commit into from
Feb 26, 2020

Conversation

Trott
Copy link
Member

@Trott Trott commented Feb 24, 2020

@not-an-aardvark confirmed in email that it's probably time for him to
move to emeritus.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Feb 24, 2020
@Trott Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Feb 24, 2020
@Trott
meta: move not-an-aardvark to emeritus
54eb7e6 
not-an-aardvark confirmed in email that it's probably time for him to
move to emeritus.

PR-URL: nodejs#31928
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Teddy Katz <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@Trott
Copy link
Member Author

Trott commented Feb 26, 2020

Landed in 54eb7e6

@Trott Trott merged commit 54eb7e6 into nodejs:master Feb 26, 2020
@Trott Trott deleted the tk branch February 26, 2020 20:00
codebytere pushed a commit that referenced this pull request Feb 27, 2020
@Trott @codebytere
meta: move not-an-aardvark to emeritus
b74c40e 
not-an-aardvark confirmed in email that it's probably time for him to
move to emeritus.

PR-URL: #31928
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Teddy Katz <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@codebytere codebytere mentioned this pull request Feb 29, 2020
Merged
codebytere pushed a commit that referenced this pull request Mar 15, 2020
@Trott @codebytere
meta: move not-an-aardvark to emeritus
7e71eb6 
not-an-aardvark confirmed in email that it's probably time for him to
move to emeritus.

PR-URL: #31928
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Teddy Katz <[email protected]>
Reviewed-By: James M Snell <[email protected]>
codebytere pushed a commit that referenced this pull request Mar 17, 2020
@Trott @codebytere
meta: move not-an-aardvark to emeritus
57a2d95 
not-an-aardvark confirmed in email that it's probably time for him to
move to emeritus.

PR-URL: #31928
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Teddy Katz <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@codebytere codebytere mentioned this pull request Mar 17, 2020
Merged
codebytere pushed a commit that referenced this pull request Mar 30, 2020
@Trott @codebytere
meta: move not-an-aardvark to emeritus
ae9f58c 
not-an-aardvark confirmed in email that it's probably time for him to
move to emeritus.

PR-URL: #31928
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Teddy Katz <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@targos targos targos approved these changes

@cjihrig cjihrig cjihrig approved these changes

@gireeshpunathil gireeshpunathil gireeshpunathil approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

@not-an-aardvark not-an-aardvark not-an-aardvark approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@Trott @jasnell @targos @cjihrig @gireeshpunathil @BridgeAR @not-an-aardvark @nodejs-github-bot