standardizes references to 'userland' issue #3189 #3192
Conversation
| @@ -2975,7 +2975,7 @@ https://iojs.org/api/tls.html | |||
| - Added async session storage events. | |||
| - Added async SNI callback. | |||
| - Added multi-key server support (for example, ECDSA+RSA server). | |||
| - Added optional callback to `checkServerIdentity` for manual certificate validation in user-land. | |||
| - Added optional callback to `checkServerIdentity` for manual certificate validation in userland. | |||
There was a problem hiding this comment.
Is it cool to change the CHANGELOG after the fact like this for what amounts to (at worst) a typo? I personally think it's totally fine but uh...anyone have a problem with it?
There was a problem hiding this comment.
It's unnecessary but harmless, in my opinion. It's in accord with the idea of standardizing the references - the more people see "userland" instead of "user-land" the more it catches on.
|
Hmmm...guess there's not that many instances to change now that I see that a handful of the files are in |
|
Yeah, changing dependency files doesn't make sense. I've undone those modifications. |
|
LGTM. |
|
@MJefferson Thanks for the contribution! If you can squash the two commits into one commit, that would be great. (And if not, no worries, I or someone else will do it when the change is landed.) If you squash the commit, it would be great if you could also change the commit message to match the guideline in the CONTIRBUTING doc. (And again, if not, I or someone else will just do it for when the change is landed.) Since it may not be clear in this case, I would use |
MJefferson
force-pushed
the
standardize-userland
branch
from
33904d0
to
70a00e1
Compare
|
Done. My pleasure @Trott. : ) |
|
Landed in f5a3f44. Thanks for the patch! |
Change occurrences of "user-land" to "userland". PR-URL: #3192 Fixes: #3189 Reviewed-By: Rich Trott <[email protected]>
Change occurrences of "user-land" to "userland". PR-URL: #3192 Fixes: #3189 Reviewed-By: Rich Trott <[email protected]>
Decided to standardize from "user-land" to "userland" as the latter appears more frequently in the docs.