-
Notifications
You must be signed in to change notification settings - Fork 30k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: fix anchor for ERR_TLS_INVALID_CONTEXT #31915
Closed
tniessen
wants to merge
1
commit into
nodejs:master
from
tniessen:doc-fix-anchor-for-errtlsinvalidcontext
Closed
doc: fix anchor for ERR_TLS_INVALID_CONTEXT #31915
tniessen
wants to merge
1
commit into
nodejs:master
from
tniessen:doc-fix-anchor-for-errtlsinvalidcontext
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
doc
Issues and PRs related to the documentations.
errors
Issues and PRs related to JavaScript errors originated in Node.js core.
labels
Feb 22, 2020
lpinca
approved these changes
Feb 22, 2020
Trott
approved these changes
Feb 22, 2020
Given that this fixes a rendering issue in the docs, I wouldn't mind fast-tracking this just to make sure it lands soon. Collaborators, 👍 here to approve fast-tracking. |
tniessen
added
the
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
label
Feb 23, 2020
cjihrig
approved these changes
Feb 23, 2020
tniessen
added a commit
that referenced
this pull request
Feb 23, 2020
PR-URL: #31915 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
tniessen
removed
the
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
label
Feb 23, 2020
codebytere
pushed a commit
that referenced
this pull request
Feb 27, 2020
PR-URL: #31915 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
Merged
targos
pushed a commit
that referenced
this pull request
Apr 18, 2020
PR-URL: #31915 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
doc
Issues and PRs related to the documentations.
errors
Issues and PRs related to JavaScript errors originated in Node.js core.
fast-track
PRs that do not need to wait for 48 hours to land.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test
(UNIX), orvcbuild test
(Windows) passes