src: include large pages source unconditionally #31904
Conversation
nodejs-github-bot
added
build
src/large_pages/node_large_page.cc
Outdated
| @@ -294,6 +296,25 @@ static bool IsSuperPagesEnabled() { | |||
| } | |||
| #endif | |||
|
|
|||
| int IsLargePagesEnabled() { | |||
There was a problem hiding this comment.
Can you name this e.g. GetLargePagesSupport()? IsLargePagesEnabled() suggests it returns a boolean when it doesn't.
Alternatively, you could just inline it at the call site; there's only one caller.
src/large_pages/node_large_page.cc
Outdated
| struct text_region r = FindNodeTextRegion(); | ||
| if (r.found_text_region == false) { | ||
| PrintWarning("failed to find text region"); | ||
| return -1; | ||
| return ENOENT; | ||
| } |
gabrielschulhof
force-pushed
the
improve-lp-cpp-flag-handling
branch
from
8a72d89 to
1ad9e86
Compare
Restrict the usage of the C preprocessor directive enabling large pages support to the large pages implementation. This cleans up the code in src/node.cc.
gabrielschulhof
force-pushed
the
improve-lp-cpp-flag-handling
branch
from
1ad9e86 to
2d72f17
Compare
|
@lundibundi @devnexen @bnoordhuis I made the requested changes, and I also made the entire implementation conditional on the preprocessor flag being defined. That is, if the flag is not defined as 1, only |
|
@bnoordhuis |
|
OTOH, |
|
@nodejs/build
This is not part of node-test-pull-request, AFAICT, so I don't know why it's here. How do I get a full-green run if this is not part of node-test-pull-request? |
|
AFAICT the failing test suite was re-run at https://ci.nodejs.org/job/node-test-commit-linux-containered/nodes=ubuntu1804_sharedlibs_shared_x64/18250/, just not updated in the statuses. |
Restrict the usage of the C preprocessor directive enabling large pages support to the large pages implementation. This cleans up the code in src/node.cc. PR-URL: #31904 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: David Carlier <[email protected]> Reviewed-By: Denys Otrishko <[email protected]>
|
Landed in 0dff851. |
Yes, the containered jobs currently only post status on failure which means they don’t get cleared when a subsequent run passes. It’s on my list of things to look at. |
Restrict the usage of the C preprocessor directive enabling large pages support to the large pages implementation. This cleans up the code in src/node.cc. PR-URL: #31904 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: David Carlier <[email protected]> Reviewed-By: Denys Otrishko <[email protected]>
Restrict the usage of the C preprocessor directive enabling large pages support to the large pages implementation. This cleans up the code in src/node.cc. PR-URL: nodejs#31904 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: David Carlier <[email protected]> Reviewed-By: Denys Otrishko <[email protected]>
Restrict the usage of the C preprocessor directive enabling large pages support to the large pages implementation. This cleans up the code in src/node.cc. PR-URL: nodejs#31904 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: David Carlier <[email protected]> Reviewed-By: Denys Otrishko <[email protected]>
|
depends on the large pages change to land on v12.x |
Restrict the usage of the C preprocessor directive enabling large pages support to the large pages implementation. This cleans up the code in src/node.cc. Backport-PR-URL: nodejs#32092 PR-URL: nodejs#31904 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: David Carlier <[email protected]> Reviewed-By: Denys Otrishko <[email protected]>
Restrict the usage of the C preprocessor directive enabling large pages support to the large pages implementation. This cleans up the code in src/node.cc. Backport-PR-URL: #32092 PR-URL: #31904 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: David Carlier <[email protected]> Reviewed-By: Denys Otrishko <[email protected]>
Restrict the usage of the C preprocessor directive enabling large
pages support to the large pages implementation. This cleans up the
code in src/node.cc.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes