Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

src: Handle NULL env scenario #31899

Closed

Conversation

HarshithaKP
Copy link
Member

Convert hard assertion into a throw with a useful error
message in src/module_wrap.cc

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the c++ Issues and PRs that require attention from people who are familiar with C++. label Feb 21, 2020
@HarshithaKP
Copy link
Member Author

While going through the file found one more similar location, fixed it.

@HarshithaKP
Copy link
Member Author

Surprisingly make format-cpp did not fix the error. Fixed it in one more commit.

Copy link
Member

@addaleax addaleax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with docs added

src/node_errors.h Outdated Show resolved Hide resolved
doc/api/errors.md Outdated Show resolved Hide resolved
src/node_errors.h Outdated Show resolved Hide resolved
Convert hard assertion into a throw with a useful error
message in src/module_wrap.cc
@HarshithaKP
Copy link
Member Author

I rebased and commits squashed

@nodejs-github-bot
Copy link
Collaborator

src/node_errors.h Outdated Show resolved Hide resolved
@addaleax addaleax added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 5, 2020
@nodejs-github-bot
Copy link
Collaborator

@addaleax
Copy link
Member

addaleax commented Mar 9, 2020

Landed in e9fa5ae

addaleax pushed a commit that referenced this pull request Mar 9, 2020
Convert hard assertion into a throw with a useful error
message in src/module_wrap.cc.

PR-URL: #31899
Reviewed-By: Anna Henningsen <[email protected]>
@addaleax addaleax closed this Mar 9, 2020
MylesBorins pushed a commit that referenced this pull request Mar 9, 2020
Convert hard assertion into a throw with a useful error
message in src/module_wrap.cc.

PR-URL: #31899
Reviewed-By: Anna Henningsen <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Mar 10, 2020
@targos targos added backport-blocked-v12.x and removed author ready PRs that have at least one approval, no pending requests for changes, and a CI started. backport-blocked-v12.x labels Apr 20, 2020
targos pushed a commit to targos/node that referenced this pull request Apr 25, 2020
Convert hard assertion into a throw with a useful error
message in src/module_wrap.cc.

PR-URL: nodejs#31899
Reviewed-By: Anna Henningsen <[email protected]>
targos pushed a commit that referenced this pull request Apr 28, 2020
Convert hard assertion into a throw with a useful error
message in src/module_wrap.cc.

PR-URL: #31899
Reviewed-By: Anna Henningsen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c++ Issues and PRs that require attention from people who are familiar with C++.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants