src: implement per-process native Debug() printer and use it in mkcodecache #31884

joyeecheung · 2020-02-20T10:03:16Z

src: make aliased_buffer.h self-contained

aliased_buffer.h uses MultiplyWithOverflowCheck() implemented
in util-inl.h

src: refactor debug category parsing

Move the debug category parsing into a new EnabledDebugList class,
so that it can be reused outside of Environment.

src: implement per-process native Debug() printer

This patch adds a per-process native Debug() printer that can be
called when an Environment is not available.

tools: use per-process native Debug() printer in mkcodecache

Checklist

make -j4 test (UNIX), or vcbuild test (Windows) passes
tests and/or benchmarks are included
documentation is changed or added
commit message follows commit guidelines

aliased_buffer.h uses MultiplyWithOverflowCheck() implemented in util-inl.h

Move the debug category parsing into a new EnabledDebugList class, so that it can be reused outside of Environment.

This patch adds a per-process native Debug() printer that can be called when an Environment is not available.

src/debug_utils.h

addaleax · 2020-02-20T11:49:51Z

src/env.h

-  bool debug_enabled_[static_cast<int>(DebugCategory::CATEGORY_COUNT)] = {
-      false};
-
+  std::unique_ptr<EnabledDebugList> enabled_debug_list_;


Is there any reason that this would need to be a pointer? I don’t think that’s necessary, and it comes with one additional layer of indirection for each debug check. One of the goals for the Debug() implementation was to have as close to zero overhead as possible, and I think this might get in the way of it…

Mostly to avoid the circular dependency - but I guess this can also be achieved by moving more things from debug_utils.h to debug_utils-inl.h so that env.h can just include debug_utils.h and debug_utils.h do not need to include env.h ?

If that works, then that would be great – otherwise we might need to move more things into env.h…

hmm, looks like if we want to keep the initialization in the constructor, then it needs to be a pointer since we'd need the environment pointer with initialized env_vars for credentials::SafeGetenv(). So I just moved the initialization into EnableDebugList::Parse(), and call it in InitializeOncePerProcess (and separately, in mkcodecache since it does not need InitializeOncePerProcess()), this also means that for now the printer is not usable until node::Start() is called in the default binary, but I guess that's fine, compared to reordering the whole initialization sequence to work around pointers.

Fwiw, what I had in mind is to use the trivial copy constructor to re-initialize it later, e.g. enabled_debug_list_ = EnabledDebugList(...);, but I guess ::Parse() works just as well :)

src/node_env_var.cc

joyeecheung · 2020-02-25T10:53:36Z

node.gyp

@@ -1225,6 +1225,16 @@
      ],

      'conditions': [
+        [ 'node_use_openssl=="true"', {


Just realized that these are necessary for the headers (esp. enums) to match in mkcodecache and node_mksnapshot binaries - hopefully all these cruft can be cleaned up when #31074 is addressed, though the last time I tried SmartOS wouldn't link, sigh.

aliased_buffer.h uses MultiplyWithOverflowCheck() implemented in util-inl.h PR-URL: #31884 Reviewed-By: Anna Henningsen <[email protected]>

Move the debug category parsing into a new EnabledDebugList class, so that it can be reused outside of Environment. PR-URL: #31884 Reviewed-By: Anna Henningsen <[email protected]>

This patch adds a per-process native Debug() printer that can be called when an Environment is not available. PR-URL: #31884 Reviewed-By: Anna Henningsen <[email protected]>

PR-URL: #31884 Reviewed-By: Anna Henningsen <[email protected]>

joyeecheung · 2020-03-10T01:07:18Z

Landed in bb6125b...192cb72, thanks!

For posterity - if you encounter linking issues after this patch please re-run configure as this patch has changed the build flags of mkcodecache and mksnapshot

aliased_buffer.h uses MultiplyWithOverflowCheck() implemented in util-inl.h PR-URL: #31884 Reviewed-By: Anna Henningsen <[email protected]>

Move the debug category parsing into a new EnabledDebugList class, so that it can be reused outside of Environment. PR-URL: #31884 Reviewed-By: Anna Henningsen <[email protected]>

This patch adds a per-process native Debug() printer that can be called when an Environment is not available. PR-URL: #31884 Reviewed-By: Anna Henningsen <[email protected]>

PR-URL: #31884 Reviewed-By: Anna Henningsen <[email protected]>

aliased_buffer.h uses MultiplyWithOverflowCheck() implemented in util-inl.h PR-URL: #31884 Reviewed-By: Anna Henningsen <[email protected]>

Move the debug category parsing into a new EnabledDebugList class, so that it can be reused outside of Environment. PR-URL: #31884 Reviewed-By: Anna Henningsen <[email protected]>

This patch adds a per-process native Debug() printer that can be called when an Environment is not available. PR-URL: #31884 Reviewed-By: Anna Henningsen <[email protected]>

PR-URL: #31884 Reviewed-By: Anna Henningsen <[email protected]>

aliased_buffer.h uses MultiplyWithOverflowCheck() implemented in util-inl.h PR-URL: #31884 Reviewed-By: Anna Henningsen <[email protected]>

Move the debug category parsing into a new EnabledDebugList class, so that it can be reused outside of Environment. PR-URL: #31884 Reviewed-By: Anna Henningsen <[email protected]>

This patch adds a per-process native Debug() printer that can be called when an Environment is not available. PR-URL: #31884 Reviewed-By: Anna Henningsen <[email protected]>

PR-URL: #31884 Reviewed-By: Anna Henningsen <[email protected]>

aliased_buffer.h uses MultiplyWithOverflowCheck() implemented in util-inl.h PR-URL: #31884 Reviewed-By: Anna Henningsen <[email protected]>

Move the debug category parsing into a new EnabledDebugList class, so that it can be reused outside of Environment. PR-URL: #31884 Reviewed-By: Anna Henningsen <[email protected]>

This patch adds a per-process native Debug() printer that can be called when an Environment is not available. PR-URL: #31884 Reviewed-By: Anna Henningsen <[email protected]>

PR-URL: #31884 Reviewed-By: Anna Henningsen <[email protected]>

joyeecheung added 4 commits February 20, 2020 18:00

src: make aliased_buffer.h self-contained

4439730

aliased_buffer.h uses MultiplyWithOverflowCheck() implemented in util-inl.h

src: refactor debug category parsing

2b80488

Move the debug category parsing into a new EnabledDebugList class, so that it can be reused outside of Environment.

src: implement per-process native Debug() printer

ce2d7fe

This patch adds a per-process native Debug() printer that can be called when an Environment is not available.

tools: use per-process native Debug() printer in mkcodecache

9abbce6

joyeecheung added c++ Issues and PRs that require attention from people who are familiar with C++. tools Issues and PRs related to the tools directory. lib / src Issues and PRs related to general changes in the lib or src directory. labels Feb 20, 2020

joyeecheung requested a review from addaleax February 20, 2020 10:03

addaleax reviewed Feb 20, 2020

View reviewed changes

joyeecheung added 3 commits February 25, 2020 17:48

fixup! src: refactor debug category parsing

c7c01d0

fixup! src: implement per-process native Debug() printer

d86480a

fixup! tools: use per-process native Debug() printer in mkcodecache

de4b6c7

joyeecheung commented Feb 25, 2020

View reviewed changes

addaleax approved these changes Feb 26, 2020

View reviewed changes

joyeecheung added a commit that referenced this pull request Mar 10, 2020

src: make aliased_buffer.h self-contained

e0f5af3

aliased_buffer.h uses MultiplyWithOverflowCheck() implemented in util-inl.h PR-URL: #31884 Reviewed-By: Anna Henningsen <[email protected]>

joyeecheung added a commit that referenced this pull request Mar 10, 2020

tools: use per-process native Debug() printer in mkcodecache

192cb72

PR-URL: #31884 Reviewed-By: Anna Henningsen <[email protected]>

joyeecheung closed this Mar 10, 2020

MylesBorins pushed a commit that referenced this pull request Mar 10, 2020

src: make aliased_buffer.h self-contained

2388a40

aliased_buffer.h uses MultiplyWithOverflowCheck() implemented in util-inl.h PR-URL: #31884 Reviewed-By: Anna Henningsen <[email protected]>

MylesBorins pushed a commit that referenced this pull request Mar 10, 2020

tools: use per-process native Debug() printer in mkcodecache

bb41383

PR-URL: #31884 Reviewed-By: Anna Henningsen <[email protected]>

MylesBorins mentioned this pull request Mar 10, 2020

v13.11.0 proposal #32185

Merged

codebytere pushed a commit that referenced this pull request Mar 23, 2020

src: make aliased_buffer.h self-contained

addc183

aliased_buffer.h uses MultiplyWithOverflowCheck() implemented in util-inl.h PR-URL: #31884 Reviewed-By: Anna Henningsen <[email protected]>

codebytere pushed a commit that referenced this pull request Mar 23, 2020

tools: use per-process native Debug() printer in mkcodecache

28bd7e3

PR-URL: #31884 Reviewed-By: Anna Henningsen <[email protected]>

codebytere mentioned this pull request Mar 24, 2020

v12.16.2 proposal #32313

Merged

codebytere pushed a commit that referenced this pull request Mar 30, 2020

src: make aliased_buffer.h self-contained

407b73a

aliased_buffer.h uses MultiplyWithOverflowCheck() implemented in util-inl.h PR-URL: #31884 Reviewed-By: Anna Henningsen <[email protected]>

codebytere pushed a commit that referenced this pull request Mar 30, 2020

tools: use per-process native Debug() printer in mkcodecache

bf44af8

PR-URL: #31884 Reviewed-By: Anna Henningsen <[email protected]>

codebytere pushed a commit that referenced this pull request Mar 31, 2020

src: make aliased_buffer.h self-contained

19f3c0a

aliased_buffer.h uses MultiplyWithOverflowCheck() implemented in util-inl.h PR-URL: #31884 Reviewed-By: Anna Henningsen <[email protected]>

codebytere pushed a commit that referenced this pull request Mar 31, 2020

tools: use per-process native Debug() printer in mkcodecache

61d54e7

PR-URL: #31884 Reviewed-By: Anna Henningsen <[email protected]>

joyeecheung mentioned this pull request Apr 18, 2020

src: include Environment in snapshot #32761

Closed

3 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

src: implement per-process native Debug() printer and use it in mkcodecache #31884

src: implement per-process native Debug() printer and use it in mkcodecache #31884

joyeecheung commented Feb 20, 2020 •

edited

Loading

addaleax Feb 20, 2020

joyeecheung Feb 20, 2020

addaleax Feb 20, 2020

joyeecheung Feb 25, 2020

addaleax Feb 26, 2020

joyeecheung Feb 25, 2020 •

edited

Loading

joyeecheung commented Mar 10, 2020 •

edited

Loading

src: implement per-process native Debug() printer and use it in mkcodecache #31884

src: implement per-process native Debug() printer and use it in mkcodecache #31884

Conversation

joyeecheung commented Feb 20, 2020 • edited Loading

src: make aliased_buffer.h self-contained

src: refactor debug category parsing

src: implement per-process native Debug() printer

tools: use per-process native Debug() printer in mkcodecache

Checklist

addaleax Feb 20, 2020

Choose a reason for hiding this comment

joyeecheung Feb 20, 2020

Choose a reason for hiding this comment

addaleax Feb 20, 2020

Choose a reason for hiding this comment

joyeecheung Feb 25, 2020

Choose a reason for hiding this comment

addaleax Feb 26, 2020

Choose a reason for hiding this comment

joyeecheung Feb 25, 2020 • edited Loading

Choose a reason for hiding this comment

joyeecheung commented Mar 10, 2020 • edited Loading

joyeecheung commented Feb 20, 2020 •

edited

Loading

joyeecheung Feb 25, 2020 •

edited

Loading

joyeecheung commented Mar 10, 2020 •

edited

Loading