stream: fix finished typo #31881
Closed
stream: fix finished typo #31881
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ronag
force-pushed
the
stream-finished-typo
branch
from
8174105
to
5c00c96
Compare
nodejs#31509 introduced a slight typo. Fortunately this typo does not have big impact due to `isWritableFinished()`. Fixes: nodejs#31509 (comment)
ronag
force-pushed
the
stream-finished-typo
branch
from
5c00c96
to
242ccc2
Compare
tniessen
reviewed
Feb 20, 2020
| @@ -312,7 +312,6 @@ testClosed((opts) => new Writable({ write() {}, ...opts })); | |||
| })); | |||
| } | |||
|
|
|||
|
|
|||
There was a problem hiding this comment.
Yea, there was an extra whitespace that shouldn't be there...
lpinca
approved these changes
Feb 20, 2020
ronag
added
the
author ready
ronag
added a commit
that referenced
this pull request
Feb 22, 2020
#31509 introduced a slight typo. Fortunately this typo does not have big impact due to `isWritableFinished()`. Fixes: #31509 (comment) PR-URL: #31881 Fixes: #31509 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
|
Landed in 21bd667 |
|
Adding don't land labels as this relies on a semver-major change |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#31509 introduced a slight typo. Fortunately this typo does not have big impact due to
isWritableFinished().Fixes: #31509 (comment)
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes