crypto: fix ieee-p1363 for createVerify #31876
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
the
c++
bnoordhuis
approved these changes
Feb 20, 2020
cjihrig
approved these changes
Feb 21, 2020
jasnell
approved these changes
Feb 21, 2020
tniessen
added a commit
that referenced
this pull request
Feb 23, 2020
Fixes: #31866 PR-URL: #31876 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
|
Landed in 0e63a07, thanks for reviewing. |
codebytere
pushed a commit
that referenced
this pull request
Feb 27, 2020
Fixes: #31866 PR-URL: #31876 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
Merged
codebytere
pushed a commit
that referenced
this pull request
Mar 15, 2020
Fixes: #31866 PR-URL: #31876 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
codebytere
pushed a commit
that referenced
this pull request
Mar 17, 2020
Fixes: #31866 PR-URL: #31876 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
Merged
codebytere
pushed a commit
that referenced
this pull request
Mar 30, 2020
Fixes: #31866 PR-URL: #31876 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Even though
createVerifywas correctly converting ieee-p1363 signatures to DER, it then passed a pointer to the ieee-p1363 signature to OpenSSL, instead of a pointer to the result of the conversion. My mistake, sorry.Fixes: #31866
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes