Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: move BaseObject subclass dtors/ctors out of node_crypto.h #31872

Closed
wants to merge 1 commit into from
Closed

src: move BaseObject subclass dtors/ctors out of node_crypto.h #31872

wants to merge 1 commit into from

Commits on Feb 19, 2020

  1. src: move BaseObject subclass dtors/ctors out of node_crypto.h 

    Originally landed in the QUIC repo

Move constructor and destructors for subclasses of `BaseObject`
from node_crypto.h to node_crypto.cc. This removes the need to
include base_object-inl.h when using node_crypto.h in some cases.

Original review metadata:

```
  PR-URL: nodejs/quic#220
  Reviewed-By: Anna Henningsen <[email protected]>
  Reviewed-By: James M Snell <[email protected]>
```
    @addaleax @jasnell
    addaleax authored and jasnell committed Feb 19, 2020
    Configuration menu
    Copy the full SHA
    df6ca6a View commit details
    Browse the repository at this point in the history