src: enable StreamPipe for generic StreamBases
#31869
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Originally landed in the nodejs/quic repo and used there for file sending. Original review: ``` PR-URL: nodejs/quic#150 Reviewed-By: James M Snell <[email protected]> ```
nodejs-github-bot
added
the
c++
addaleax
approved these changes
Feb 19, 2020
4 tasks
danbev
approved these changes
Feb 20, 2020
jasnell
added
the
author ready
|
The only CI failure here is the known flaky known-issue test: #31966 |
jasnell
pushed a commit
that referenced
this pull request
Feb 26, 2020
Originally landed in the nodejs/quic repo and used there for file sending. Original review: ``` PR-URL: nodejs/quic#150 Reviewed-By: James M Snell <[email protected]> ``` PR-URL: #31869 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]>
|
Landed in b44c63b |
codebytere
pushed a commit
that referenced
this pull request
Feb 27, 2020
Originally landed in the nodejs/quic repo and used there for file sending. Original review: ``` PR-URL: nodejs/quic#150 Reviewed-By: James M Snell <[email protected]> ``` PR-URL: #31869 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]>
Merged
3 tasks
codebytere
pushed a commit
that referenced
this pull request
Mar 15, 2020
Originally landed in the nodejs/quic repo and used there for file sending. Original review: ``` PR-URL: nodejs/quic#150 Reviewed-By: James M Snell <[email protected]> ``` PR-URL: #31869 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]>
codebytere
pushed a commit
that referenced
this pull request
Mar 17, 2020
Originally landed in the nodejs/quic repo and used there for file sending. Original review: ``` PR-URL: nodejs/quic#150 Reviewed-By: James M Snell <[email protected]> ``` PR-URL: #31869 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]>
Merged
codebytere
pushed a commit
that referenced
this pull request
Mar 30, 2020
Originally landed in the nodejs/quic repo and used there for file sending. Original review: ``` PR-URL: nodejs/quic#150 Reviewed-By: James M Snell <[email protected]> ``` PR-URL: #31869 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Authored by @addaleax and landed in the nodejs/quic repo and used there for efficient file sending. Separating this out from the main QUIC PR to help reduce the size. There is no QUIC specific details in this, however.
Original review metadata:
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes