Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

meta: move julianduque to emeritus #31863

Merged
merged 0 commits into from
Feb 21, 2020
Merged

meta: move julianduque to emeritus #31863

merged 0 commits into from
Feb 21, 2020

Conversation

Trott
Copy link
Member

@Trott Trott commented Feb 19, 2020

julianduque confirmed in email that they can be moved to emeritus.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Feb 19, 2020
@Trott
Copy link
Member Author

Trott commented Feb 19, 2020

@julianduque

@Trott Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Feb 19, 2020
mhdawson
mhdawson approved these changes Feb 19, 2020
View reviewed changes
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Trott
Copy link
Member Author

Trott commented Feb 21, 2020

Landed in 2f97e97

@Trott Trott closed this Feb 21, 2020
@Trott Trott merged commit 2f97e97 into nodejs:master Feb 21, 2020
@Trott Trott deleted the emeritus-jd branch February 21, 2020 17:16
@sthagen sthagen mentioned this pull request Feb 21, 2020
Merged
4 tasks
codebytere pushed a commit that referenced this pull request Feb 27, 2020
@Trott @codebytere
meta: move julianduque to emeritus
61a0d8b 
julianduque confirmed in email that they can be moved to emeritus.

PR-URL: #31863
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Сковорода Никита Андреевич <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
@codebytere codebytere mentioned this pull request Feb 29, 2020
Merged
codebytere pushed a commit that referenced this pull request Mar 15, 2020
@Trott @codebytere
meta: move julianduque to emeritus
dc1fe26 
julianduque confirmed in email that they can be moved to emeritus.

PR-URL: #31863
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Сковорода Никита Андреевич <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
codebytere pushed a commit that referenced this pull request Mar 17, 2020
@Trott @codebytere
meta: move julianduque to emeritus
382d904 
julianduque confirmed in email that they can be moved to emeritus.

PR-URL: #31863
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Сковорода Никита Андреевич <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
@codebytere codebytere mentioned this pull request Mar 17, 2020
Merged
@julianduque
Copy link
Contributor

I'll be back ;)

codebytere pushed a commit that referenced this pull request Mar 30, 2020
@Trott @codebytere
meta: move julianduque to emeritus
9251307 
julianduque confirmed in email that they can be moved to emeritus.

PR-URL: #31863
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Сковорода Никита Андреевич <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@randombluff randombluff randombluff approved these changes

@mhdawson mhdawson mhdawson approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

@gireeshpunathil gireeshpunathil gireeshpunathil approved these changes

@tniessen tniessen tniessen approved these changes

@cjihrig cjihrig cjihrig approved these changes

@ChALkeR ChALkeR ChALkeR approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@Trott @julianduque @ChALkeR @cjihrig @tniessen @gireeshpunathil @BridgeAR @mhdawson @randombluff @nodejs-github-bot