stream: fix broken pipeline error propagation #31835
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ronag
commented
Feb 17, 2020
ronag
commented
Feb 17, 2020
ronag
force-pushed
the
stream-pipeline-broken-test
branch
from
2b052e0
to
ca5b7ff
Compare
mcollina
reviewed
Feb 19, 2020
ronag
commented
Feb 19, 2020
ronag
force-pushed
the
stream-pipeline-broken-test
branch
from
eae965f
to
d1533fe
Compare
|
Confusion resolved. There was a @nodejs/streams PTAL |
ronag
force-pushed
the
stream-pipeline-broken-test
branch
from
22b2dd6
to
d0860a6
Compare
ronag
added
the
author ready
ronag
force-pushed
the
stream-pipeline-broken-test
branch
3 times, most recently
from
ce8e95d
to
d3df498
Compare
ronag
changed the title
If the destination was an async function any error thrown from that function would be swallowed.
ronag
force-pushed
the
stream-pipeline-broken-test
branch
from
d3df498
to
f07a2d1
Compare
benjamingr
approved these changes
Feb 22, 2020
benjamingr
reviewed
Feb 22, 2020
lundibundi
approved these changes
Feb 22, 2020
Co-Authored-By: Denys Otrishko <[email protected]>
ronag
added a commit
that referenced
this pull request
Feb 24, 2020
If the destination was an async function any error thrown from that function would be swallowed. PR-URL: #31835 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Denys Otrishko <[email protected]>
|
Landed in db28739 |
ronag
added a commit
to nxtedition/node
that referenced
this pull request
Feb 27, 2020
If the destination was an async function any error thrown from that function would be swallowed. Backport-PR-URL: nodejs#31975 PR-URL: nodejs#31835 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Denys Otrishko <[email protected]>
codebytere
pushed a commit
that referenced
this pull request
Mar 1, 2020
If the destination was an async function any error thrown from that function would be swallowed. Backport-PR-URL: #31975 PR-URL: #31835 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Denys Otrishko <[email protected]>
Merged
|
Should this land on v12.x-staging? If so, please open a backport PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the destination was an async function any error thrown from that function would be swallowed.
EDITED
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes