async_hooks: executionAsyncResource matches in hooks #31821
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
the
c++
addaleax
approved these changes
Feb 16, 2020
JungMinu
approved these changes
Feb 17, 2020
legendecas
approved these changes
Feb 18, 2020
Qard
approved these changes
Feb 18, 2020
vdeturckheim
approved these changes
Feb 18, 2020
vdeturckheim
added
the
async_hooks
|
Seems the test I added here fails in node-test-commit-custom-suites-freestyle. Will take a look later. Any hints whats spacial about this CI job are welcome. |
|
@Flarna Not sure why the job is named that way but it’s basically running each test inside a Worker thread, i.e. |
Qard
approved these changes
Feb 25, 2020
|
@Flarna the issue seems fixed, is it ready for a rebase? |
|
From my point of view it's ready for landing. |
|
@Flarna can you please squash it to a single commit? |
|
Sure, but why is this needed here? |
|
It's indeed doable at merge time but I don't like rewriting other people's commits 😅 |
Ensure that resource returned by executionAsyncResource() in before and after hook matches that resource causing this before/after calls.
Flarna
force-pushed
the
async-exe-resoure-match
branch
from
cbe78d1 to
19fbe32
Compare
|
Ok, rebased and squashed. Not sure if CI needs to run again now. I was assuming that squashin is done by some landing script or similar. Commits are rewritten anyway during landing as PR url, list of revierers is added. |
|
Thanks @Flarna , I'll restart CI. |
vdeturckheim
added
the
author ready
|
Landed in fd3d02a |
vdeturckheim
pushed a commit
that referenced
this pull request
Feb 26, 2020
Ensure that resource returned by executionAsyncResource() in before and after hook matches that resource causing this before/after calls. PR-URL: #31821 Refs: #30959 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Minwoo Jung <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Stephen Belanger <[email protected]> Reviewed-By: Vladimir de Turckheim <[email protected]>
codebytere
pushed a commit
that referenced
this pull request
Feb 27, 2020
Ensure that resource returned by executionAsyncResource() in before and after hook matches that resource causing this before/after calls. PR-URL: #31821 Refs: #30959 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Minwoo Jung <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Stephen Belanger <[email protected]> Reviewed-By: Vladimir de Turckheim <[email protected]>
Merged
targos
added
backported-to-v12.x
and removed
author ready
4 tasks
puzpuzpuz
pushed a commit
to puzpuzpuz/node
that referenced
this pull request
Apr 14, 2020
Ensure that resource returned by executionAsyncResource() in before and after hook matches that resource causing this before/after calls. PR-URL: nodejs#31821 Refs: nodejs#30959 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Minwoo Jung <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Stephen Belanger <[email protected]> Reviewed-By: Vladimir de Turckheim <[email protected]>
puzpuzpuz
pushed a commit
to puzpuzpuz/node
that referenced
this pull request
Apr 14, 2020
Ensure that resource returned by executionAsyncResource() in before and after hook matches that resource causing this before/after calls. PR-URL: nodejs#31821 Refs: nodejs#30959 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Minwoo Jung <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Stephen Belanger <[email protected]> Reviewed-By: Vladimir de Turckheim <[email protected]>
targos
pushed a commit
to targos/node
that referenced
this pull request
Apr 25, 2020
Ensure that resource returned by executionAsyncResource() in before and after hook matches that resource causing this before/after calls. PR-URL: nodejs#31821 Refs: nodejs#30959 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Minwoo Jung <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Stephen Belanger <[email protected]> Reviewed-By: Vladimir de Turckheim <[email protected]>
targos
pushed a commit
that referenced
this pull request
Apr 28, 2020
Ensure that resource returned by executionAsyncResource() in before and after hook matches that resource causing this before/after calls. PR-URL: #31821 Refs: #30959 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Minwoo Jung <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Stephen Belanger <[email protected]> Reviewed-By: Vladimir de Turckheim <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure that resource returned by
executionAsyncResource()in before and after hook matches that resource causing this before/after calls.Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesRefs: #30959
fyi @Qard