doc: add zlib maintenance doc #31800
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
jasnell
approved these changes
Feb 14, 2020
mscdex
reviewed
Feb 14, 2020
mscdex
reviewed
Feb 14, 2020
cjihrig
approved these changes
Feb 15, 2020
sam-github
force-pushed
the
update-zlib
branch
from
c2d51de to
78cc6c9
Compare
deps/zlib/README.md is not part of the upstream zlib, it is a Node.js specific addition describing how to maintain zlib and should be in doc/guides/.
Updated as described in doc/guides/maintaining-zlib.md.
sam-github
force-pushed
the
update-zlib
branch
from
78cc6c9 to
f70ebe6
Compare
BethGriggs
approved these changes
Feb 24, 2020
|
Landed in b70dd9d...9a1719b |
sam-github
added a commit
that referenced
this pull request
Feb 24, 2020
deps/zlib/README.md is not part of the upstream zlib, it is a Node.js specific addition describing how to maintain zlib and should be in doc/guides/. PR-URL: #31800 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Beth Griggs <[email protected]>
sam-github
added a commit
that referenced
this pull request
Feb 24, 2020
See: - #31201 PR-URL: #31800 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Beth Griggs <[email protected]>
sam-github
added a commit
that referenced
this pull request
Feb 24, 2020
Updated as described in doc/guides/maintaining-zlib.md. PR-URL: #31800 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Beth Griggs <[email protected]>
codebytere
pushed a commit
that referenced
this pull request
Feb 27, 2020
deps/zlib/README.md is not part of the upstream zlib, it is a Node.js specific addition describing how to maintain zlib and should be in doc/guides/. PR-URL: #31800 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Beth Griggs <[email protected]>
codebytere
pushed a commit
that referenced
this pull request
Feb 27, 2020
See: - #31201 PR-URL: #31800 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Beth Griggs <[email protected]>
codebytere
pushed a commit
that referenced
this pull request
Feb 27, 2020
Updated as described in doc/guides/maintaining-zlib.md. PR-URL: #31800 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Beth Griggs <[email protected]>
Merged
codebytere
pushed a commit
that referenced
this pull request
Mar 15, 2020
deps/zlib/README.md is not part of the upstream zlib, it is a Node.js specific addition describing how to maintain zlib and should be in doc/guides/. PR-URL: #31800 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Beth Griggs <[email protected]>
codebytere
pushed a commit
that referenced
this pull request
Mar 15, 2020
See: - #31201 PR-URL: #31800 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Beth Griggs <[email protected]>
codebytere
pushed a commit
that referenced
this pull request
Mar 15, 2020
Updated as described in doc/guides/maintaining-zlib.md. PR-URL: #31800 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Beth Griggs <[email protected]>
codebytere
pushed a commit
that referenced
this pull request
Mar 17, 2020
deps/zlib/README.md is not part of the upstream zlib, it is a Node.js specific addition describing how to maintain zlib and should be in doc/guides/. PR-URL: #31800 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Beth Griggs <[email protected]>
codebytere
pushed a commit
that referenced
this pull request
Mar 17, 2020
See: - #31201 PR-URL: #31800 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Beth Griggs <[email protected]>
codebytere
pushed a commit
that referenced
this pull request
Mar 17, 2020
Updated as described in doc/guides/maintaining-zlib.md. PR-URL: #31800 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Beth Griggs <[email protected]>
Merged
|
depends on the zlib update to land on v12.x |
targos
pushed a commit
to targos/node
that referenced
this pull request
Apr 25, 2020
deps/zlib/README.md is not part of the upstream zlib, it is a Node.js specific addition describing how to maintain zlib and should be in doc/guides/. PR-URL: nodejs#31800 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Beth Griggs <[email protected]>
targos
pushed a commit
to targos/node
that referenced
this pull request
Apr 25, 2020
See: - nodejs#31201 PR-URL: nodejs#31800 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Beth Griggs <[email protected]>
targos
pushed a commit
to targos/node
that referenced
this pull request
Apr 25, 2020
Updated as described in doc/guides/maintaining-zlib.md. PR-URL: nodejs#31800 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Beth Griggs <[email protected]>
targos
pushed a commit
that referenced
this pull request
Apr 28, 2020
deps/zlib/README.md is not part of the upstream zlib, it is a Node.js specific addition describing how to maintain zlib and should be in doc/guides/. PR-URL: #31800 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Beth Griggs <[email protected]>
targos
pushed a commit
that referenced
this pull request
Apr 28, 2020
See: - #31201 PR-URL: #31800 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Beth Griggs <[email protected]>
targos
pushed a commit
that referenced
this pull request
Apr 28, 2020
Updated as described in doc/guides/maintaining-zlib.md. PR-URL: #31800 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Beth Griggs <[email protected]>
|
Hi Sam, We fixed a zlib bug in Chromium recently (https://crbug.com/1103818) which can cause incorrect inflate results when using newer Clang versions. It might be worth rolling forward again to pick up that fix. Also it seems there's another copy of zlib in Node that comes in via V8's dependencies: https://github.com/nodejs/node/tree/master/deps/v8/third_party/zlib Thanks, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a maintenance doc for deps/zlib, and run the process.
Result is an almost entirely empty "update" (only the mode of one file was different from upstream).
Note: we changed to using a google repo as upstream in #31201
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes