-
Notifications
You must be signed in to change notification settings - Fork 30k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: update stream.pipeline() signature #31789
doc: update stream.pipeline() signature #31789
Conversation
The `...transforms` parameter seems optional. Refs: https://github.com/nodejs/node/blob/087583741716969edf12874d4f1f1774de581f50/lib/internal/streams/pipeline.js#L130-L132 Refs: https://github.com/nodejs/node/blob/e559842188f541b884abff2ffad4d2d3e1b841a6/doc/api/stream.md#streams-compatibility-with-async-generators-and-async-iterators (see the last example)
Isn't |
Yes, but the |
Sorry, I did not even consider |
And it seems this pattern is used: |
The `...transforms` parameter is optional. Refs: https://github.com/nodejs/node/blob/0875837417/lib/internal/streams/pipeline.js#L130-L132 Refs: https://github.com/nodejs/node/blob/e559842188/doc/api/stream.md#streams-compatibility-with-async-generators-and-async-iterators PR-URL: #31789 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Robert Nagy <[email protected]> Reviewed-By: Yongsheng Zhang <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
Landed in 2f23918. |
The `...transforms` parameter is optional. Refs: https://github.com/nodejs/node/blob/0875837417/lib/internal/streams/pipeline.js#L130-L132 Refs: https://github.com/nodejs/node/blob/e559842188/doc/api/stream.md#streams-compatibility-with-async-generators-and-async-iterators PR-URL: #31789 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Robert Nagy <[email protected]> Reviewed-By: Yongsheng Zhang <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
Checklist
make -j4 test
(UNIX), orvcbuild test
(Windows) passesThe
...transforms
parameter seems optional.Refs:
node/lib/internal/streams/pipeline.js
Lines 130 to 132 in 0875837
Refs: https://github.com/nodejs/node/blob/e559842188f541b884abff2ffad4d2d3e1b841a6/doc/api/stream.md#streams-compatibility-with-async-generators-and-async-iterators
(see the last example)