Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: move gireeshpunathil to TSC emeritus #31770

Closed
wants to merge 1 commit into from
Closed

doc: move gireeshpunathil to TSC emeritus #31770

wants to merge 1 commit into from

Conversation

gireeshpunathil
Copy link
Member

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

to meet the TSC membership guidelines in terms of employer representation distribution in the team.

blocked on: #31725
Fixes: nodejs/TSC#817

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Feb 13, 2020
mhdawson
mhdawson approved these changes Feb 14, 2020
View reviewed changes
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gireeshpunathil
Copy link
Member Author

CI-lie: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/4129/

@gireeshpunathil gireeshpunathil changed the title [WIP] doc: move gireeshpunathil to TSC emeritus doc: move gireeshpunathil to TSC emeritus Feb 17, 2020
@gireeshpunathil gireeshpunathil added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Feb 17, 2020
gireeshpunathil added a commit that referenced this pull request Feb 17, 2020
@gireeshpunathil
doc: move gireeshpunathil to TSC emeritus
4c746a6 
PR-URL: #31770
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Myles Borins <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
@gireeshpunathil
Copy link
Member Author

landed in 4c746a6

@gireeshpunathil
Copy link
Member Author

@mhdawson @Trott - do you know if there are other formalities that required to complete the formalities here - such as removing from email listings, tsc meeting lists, org-wide elevated privileges, etc. ?

@Trott
Copy link
Member

Trott commented Feb 18, 2020

@mhdawson @Trott - do you know if there are other formalities that required to complete the formalities here - such as removing from email listings, tsc meeting lists, org-wide elevated privileges, etc. ?

They are listed at https://github.com/nodejs/TSC/blob/master/ONBOARDING.md#offboarding. I took care of most of them. I am unable to handle the HackerOne part (/ping @sam-github) and we need to add you back to the meeting template as a guest. Other than that, I think they are all done.

codebytere pushed a commit that referenced this pull request Feb 27, 2020
@gireeshpunathil @codebytere
doc: move gireeshpunathil to TSC emeritus
f952605 
PR-URL: #31770
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Myles Borins <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
@codebytere codebytere mentioned this pull request Feb 29, 2020
Merged
codebytere pushed a commit that referenced this pull request Mar 15, 2020
@gireeshpunathil @codebytere
doc: move gireeshpunathil to TSC emeritus
5277cd0 
PR-URL: #31770
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Myles Borins <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
codebytere pushed a commit that referenced this pull request Mar 17, 2020
@gireeshpunathil @codebytere
doc: move gireeshpunathil to TSC emeritus
b8e51a2 
PR-URL: #31770
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Myles Borins <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
@codebytere codebytere mentioned this pull request Mar 17, 2020
Merged
codebytere pushed a commit that referenced this pull request Mar 30, 2020
@gireeshpunathil @codebytere
doc: move gireeshpunathil to TSC emeritus
aebaead 
PR-URL: #31770
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Myles Borins <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhdawson mhdawson mhdawson approved these changes

@richardlau richardlau richardlau approved these changes

@tniessen tniessen tniessen approved these changes

@cjihrig cjihrig cjihrig approved these changes

@lpinca lpinca lpinca approved these changes

@MylesBorins MylesBorins MylesBorins approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Timing of TSC member addition / resignation
10 participants
@gireeshpunathil @Trott @jasnell @MylesBorins @lpinca @cjihrig @tniessen @richardlau @mhdawson @nodejs-github-bot