Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: remove common.PORT from some pummel tests #31749

Merged
merged 4 commits into from
Feb 18, 2020
Merged

test: remove common.PORT from some pummel tests #31749

merged 4 commits into from
Feb 18, 2020

Commits on Feb 18, 2020

  1. test: remove common.PORT from test-net-timeout 

    Switch test-net-timeout from common.PORT to a port assigned by the
operating system.

PR-URL: nodejs#31749
Reviewed-By: Denys Otrishko <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
    @Trott
    Trott committed Feb 18, 2020
    Configuration menu
    Copy the full SHA
    794bfac View commit details
    Browse the repository at this point in the history

  2. test: remove common.PORT from test-net-throttle 

    Switch test-net-throttle from common.PORT to a port assigned by the
operating system.

PR-URL: nodejs#31749
Reviewed-By: Denys Otrishko <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
    @Trott
    Trott committed Feb 18, 2020
    Configuration menu
    Copy the full SHA
    76fd17a View commit details
    Browse the repository at this point in the history

  3. test: remove common.PORT from test-tls-server-large-request 

    Switch test-tls-server-large-request from common.PORT to a port assigned
by the operating system.

PR-URL: nodejs#31749
Reviewed-By: Denys Otrishko <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
    @Trott
    Trott committed Feb 18, 2020
    Configuration menu
    Copy the full SHA
    a092886 View commit details
    Browse the repository at this point in the history

  4. test: remove common.PORT from test-net-pause 

    Switch test-net-pause from common.PORT to a port assigned by the
operating system.

PR-URL: nodejs#31749
Reviewed-By: Denys Otrishko <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
    @Trott
    Trott committed Feb 18, 2020
    Configuration menu
    Copy the full SHA
    af19f41 View commit details
    Browse the repository at this point in the history