Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

meta: move princejwesley to emeritus #31730

Closed
wants to merge 1 commit into from
Closed

meta: move princejwesley to emeritus #31730

wants to merge 1 commit into from

Conversation

Trott
Copy link
Member

@Trott Trott commented Feb 11, 2020

princejwesley confirmed in email that moving to emeritus at this time
was appropriate.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

@Trott
meta: move princejwesley to emeritus
544a559 
princejwesley confirmed in email that moving to emeritus at this time
was appropriate.
@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Feb 11, 2020
@Trott
Copy link
Member Author

Trott commented Feb 11, 2020

@princejwesley

@Trott Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Feb 11, 2020
@addaleax
Copy link
Member

Landed in ff82b76

@addaleax addaleax closed this Feb 13, 2020
addaleax pushed a commit that referenced this pull request Feb 13, 2020
@Trott @addaleax
meta: move princejwesley to emeritus
ff82b76 
princejwesley confirmed in email that moving to emeritus at this time
was appropriate.

PR-URL: #31730
Reviewed-By: Gus Caplan <[email protected]>
Reviewed-By: Yongsheng Zhang <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
codebytere pushed a commit that referenced this pull request Feb 17, 2020
@Trott @codebytere
meta: move princejwesley to emeritus
15c8d9e 
princejwesley confirmed in email that moving to emeritus at this time
was appropriate.

PR-URL: #31730
Reviewed-By: Gus Caplan <[email protected]>
Reviewed-By: Yongsheng Zhang <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
@codebytere codebytere mentioned this pull request Feb 17, 2020
Merged
codebytere pushed a commit that referenced this pull request Mar 15, 2020
@Trott @codebytere
meta: move princejwesley to emeritus
04bf5bf 
princejwesley confirmed in email that moving to emeritus at this time
was appropriate.

PR-URL: #31730
Reviewed-By: Gus Caplan <[email protected]>
Reviewed-By: Yongsheng Zhang <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
codebytere pushed a commit that referenced this pull request Mar 17, 2020
@Trott @codebytere
meta: move princejwesley to emeritus
2ae5aff 
princejwesley confirmed in email that moving to emeritus at this time
was appropriate.

PR-URL: #31730
Reviewed-By: Gus Caplan <[email protected]>
Reviewed-By: Yongsheng Zhang <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
@codebytere codebytere mentioned this pull request Mar 17, 2020
Merged
codebytere pushed a commit that referenced this pull request Mar 30, 2020
@Trott @codebytere
meta: move princejwesley to emeritus
c222d56 
princejwesley confirmed in email that moving to emeritus at this time
was appropriate.

PR-URL: #31730
Reviewed-By: Gus Caplan <[email protected]>
Reviewed-By: Yongsheng Zhang <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
@Trott Trott deleted the emeritus-2 branch April 14, 2022 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@targos targos targos approved these changes

@cjihrig cjihrig cjihrig approved these changes

@devsnek devsnek devsnek approved these changes

@gireeshpunathil gireeshpunathil gireeshpunathil approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

@ZYSzys ZYSzys ZYSzys approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@Trott @addaleax @jasnell @targos @cjihrig @devsnek @gireeshpunathil @BridgeAR @ZYSzys @nodejs-github-bot