-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: update zlib doc #31665
doc: update zlib doc #31665
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still LGTM
Trying again: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/4136/ |
Just some general improvements to zlib docs and examples Signed-off-by: James M Snell <[email protected]>
c511798
to
919651b
Compare
Just some general improvements to zlib docs and examples Signed-off-by: James M Snell <[email protected]> PR-URL: #31665 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Landed in c6ed01c |
Not sure if this was kicked off for some other reason and you already are aware of this, but just in case: FYI we changed the landing rules and lite CI is generally not needed anymore if Travis passed. #30330 |
Just some general improvements to zlib docs and examples Signed-off-by: James M Snell <[email protected]> PR-URL: #31665 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Just some general improvements to zlib docs and examples Signed-off-by: James M Snell <[email protected]> PR-URL: #31665 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Just some general improvements to zlib docs and examples Signed-off-by: James M Snell <[email protected]> PR-URL: #31665 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Just some general improvements to zlib docs and examples Signed-off-by: James M Snell <[email protected]> PR-URL: #31665 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Just some general improvements to zlib docs and examples