Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fix flaky test-inspector-connect-main-thread #31637

Commits on Feb 4, 2020

  1. test: fix flaky test-inspector-connect-main-thread

    Previously, the test waited for a (any) message from the workers,
    and then attached another event listener to a specific kind of
    message. However, it was possible that the second listener was
    attached after the Worker had already exited, thus never receiving
    the message it was supposed to receive. (This is the race condition
    here – usually, the Worker thread would exit *after* the second
    listener was attached.)
    
    Solve this by keeping a single `'message'` event listener attached
    to the worker instance during its entire lifetime.
    
    Fixes: nodejs#31226
    addaleax committed Feb 4, 2020
    Configuration menu
    Copy the full SHA
    f74813e View commit details
    Browse the repository at this point in the history