fs: set path when mkdir recursive called on file #31607
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
c++
|
If folks are open to it, I would love to fast track this fix. |
This comment has been minimized.
This comment has been minimized.
addaleax
approved these changes
Feb 1, 2020
This comment has been minimized.
This comment has been minimized.
richardlau
reviewed
Feb 1, 2020
bcoe
commented
Feb 2, 2020
| @@ -1398,7 +1400,6 @@ int MKDirpAsync(uv_loop_t* loop, | |||
| } | |||
| // verify that the path pointed to is actually a directory. | |||
| if (err == 0 && !S_ISDIR(req->statbuf.st_mode)) err = UV_EEXIST; | |||
| uv_fs_req_cleanup(req); | |||
There was a problem hiding this comment.
We were calling uv_fs_req_cleanup prematurely on Windows systems, and freeing req->path.
uv_fs_req_cleanup is called in FSReqAfterScope::~FSReqAfterScope().
This comment has been minimized.
This comment has been minimized.
bcoe
added
the
author ready
This comment has been minimized.
This comment has been minimized.
Trott
approved these changes
Feb 3, 2020
lpinca
approved these changes
Feb 3, 2020
|
@richardlau mind if I land? |
richardlau
approved these changes
Feb 3, 2020
Go for it 😀. |
bcoe
added a commit
that referenced
this pull request
Feb 3, 2020
PR-URL: #31607 Fixes: #28015 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Richard Lau <[email protected]>
|
Landed in 3f70d77 |
codebytere
pushed a commit
that referenced
this pull request
Feb 17, 2020
PR-URL: #31607 Fixes: #28015 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Richard Lau <[email protected]>
Merged
codebytere
pushed a commit
that referenced
this pull request
Mar 15, 2020
PR-URL: #31607 Fixes: #28015 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Richard Lau <[email protected]>
codebytere
pushed a commit
that referenced
this pull request
Mar 17, 2020
PR-URL: #31607 Fixes: #28015 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Richard Lau <[email protected]>
Merged
codebytere
pushed a commit
that referenced
this pull request
Mar 30, 2020
PR-URL: #31607 Fixes: #28015 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Richard Lau <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar fix to #31505, we should bail early if mkdir recursive is called on a file path.
Fixes: #28015
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes