Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: remove unused Worker::child_port_ member #31599

Closed
wants to merge 1 commit into from
Closed

src: remove unused Worker::child_port_ member #31599

wants to merge 1 commit into from

Conversation

addaleax
Copy link
Member

@addaleax addaleax commented Feb 1, 2020

This fixes a compiler warning introduced in 9225939.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@addaleax
src: remove unused Worker::child_port_ member
7735b2a 
This fixes a compiler warning introduced in 9225939.
@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. worker Issues and PRs related to Worker support. labels Feb 1, 2020
@danbev
Copy link
Contributor

danbev commented Feb 3, 2020

CI-lite: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/4127/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/28895/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/28915/

@danbev danbev added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Feb 4, 2020
danbev pushed a commit that referenced this pull request Feb 4, 2020
@addaleax @danbev
src: remove unused Worker::child_port_ member
60de60a 
This fixes a compiler warning introduced in 9225939.

PR-URL: #31599
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
@danbev
Copy link
Contributor

danbev commented Feb 4, 2020

Landed in 60de60a.

@danbev danbev closed this Feb 4, 2020
codebytere pushed a commit that referenced this pull request Feb 17, 2020
@addaleax @codebytere
src: remove unused Worker::child_port_ member
425662e 
This fixes a compiler warning introduced in 9225939.

PR-URL: #31599
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
@codebytere codebytere mentioned this pull request Feb 17, 2020
Merged
codebytere pushed a commit that referenced this pull request Mar 15, 2020
@addaleax @codebytere
src: remove unused Worker::child_port_ member
ae9ea95 
This fixes a compiler warning introduced in 9225939.

PR-URL: #31599
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
codebytere pushed a commit that referenced this pull request Mar 17, 2020
@addaleax @codebytere
src: remove unused Worker::child_port_ member
f434c8c 
This fixes a compiler warning introduced in 9225939.

PR-URL: #31599
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
@codebytere codebytere mentioned this pull request Mar 17, 2020
Merged
codebytere pushed a commit that referenced this pull request Mar 30, 2020
@addaleax @codebytere
src: remove unused Worker::child_port_ member
753db6a 
This fixes a compiler warning introduced in 9225939.

PR-URL: #31599
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gireeshpunathil gireeshpunathil gireeshpunathil approved these changes

@cjihrig cjihrig cjihrig approved these changes

@lpinca lpinca lpinca approved these changes

@Trott Trott Trott approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. worker Issues and PRs related to Worker support.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@addaleax @danbev @nodejs-github-bot @jasnell @Trott @lpinca @cjihrig @gireeshpunathil