Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tools: replace deprecated iteritems() for items() #31528

Closed
wants to merge 1 commit into from
Closed

tools: replace deprecated iteritems() for items() #31528

wants to merge 1 commit into from

Conversation

Gioyik
Copy link
Contributor

@Gioyik Gioyik commented Jan 26, 2020

This is a Built-In change in Python 3 used by compile_commands_json.py
to generate compile_commands_json.json. Node.js dropped Python 2 support
in this script, items() works as expected replacement.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@Gioyik
tools: replace deprecated iteritems() for items()
b52e259 
This is a Built-In change in Python 3 used by compile_commands_json.py
to generate compile_commands_json.json. Node.js dropped Python 2 support
in this script, `items()` works as expected replacement.
@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to build files or the CI. tools Issues and PRs related to the tools directory. labels Jan 26, 2020
@richardlau richardlau added the python PRs and issues that require attention from people who are familiar with Python. label Jan 27, 2020
@Trott
Copy link
Member

Trott commented Jan 28, 2020

@nodejs/python

@richardlau
Copy link
Member

richardlau commented Jan 28, 2020 •
edited
Loading

For reference, here's the equivalent commit to the version of gyp embedded in node-gyp: nodejs/node-gyp@c0282da

@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/28747/

@Trott
Copy link
Member

Trott commented Jan 29, 2020

Landed in 64161f2

@Trott Trott closed this Jan 29, 2020
Trott pushed a commit that referenced this pull request Jan 29, 2020
@Gioyik @Trott
tools: replace deprecated iteritems() for items()
64161f2 
This is a Built-In change in Python 3 used by compile_commands_json.py
to generate compile_commands_json.json. Node.js dropped Python 2 support
in this script, `items()` works as expected replacement.

PR-URL: #31528
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Minwoo Jung <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Christian Clauss <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
codebytere pushed a commit that referenced this pull request Feb 17, 2020
@Gioyik @codebytere
tools: replace deprecated iteritems() for items()
39c86bb 
This is a Built-In change in Python 3 used by compile_commands_json.py
to generate compile_commands_json.json. Node.js dropped Python 2 support
in this script, `items()` works as expected replacement.

PR-URL: #31528
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Minwoo Jung <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Christian Clauss <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
@codebytere codebytere mentioned this pull request Feb 17, 2020
Merged
codebytere pushed a commit that referenced this pull request Mar 15, 2020
@Gioyik @codebytere
tools: replace deprecated iteritems() for items()
98708a5 
This is a Built-In change in Python 3 used by compile_commands_json.py
to generate compile_commands_json.json. Node.js dropped Python 2 support
in this script, `items()` works as expected replacement.

PR-URL: #31528
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Minwoo Jung <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Christian Clauss <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
codebytere pushed a commit that referenced this pull request Mar 17, 2020
@Gioyik @codebytere
tools: replace deprecated iteritems() for items()
82b3591 
This is a Built-In change in Python 3 used by compile_commands_json.py
to generate compile_commands_json.json. Node.js dropped Python 2 support
in this script, `items()` works as expected replacement.

PR-URL: #31528
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Minwoo Jung <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Christian Clauss <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
@codebytere codebytere mentioned this pull request Mar 17, 2020
Merged
codebytere pushed a commit that referenced this pull request Mar 30, 2020
@Gioyik @codebytere
tools: replace deprecated iteritems() for items()
289f3dc 
This is a Built-In change in Python 3 used by compile_commands_json.py
to generate compile_commands_json.json. Node.js dropped Python 2 support
in this script, `items()` works as expected replacement.

PR-URL: #31528
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Minwoo Jung <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Christian Clauss <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bnoordhuis bnoordhuis bnoordhuis approved these changes

@Trott Trott Trott approved these changes

@cjihrig cjihrig cjihrig approved these changes

@cclauss cclauss cclauss approved these changes

@JungMinu JungMinu JungMinu approved these changes

@richardlau richardlau richardlau approved these changes

Assignees
No one assigned
Labels
build Issues and PRs related to build files or the CI. python PRs and issues that require attention from people who are familiar with Python. tools Issues and PRs related to the tools directory.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@Gioyik @Trott @richardlau @nodejs-github-bot @bnoordhuis @cjihrig @cclauss @JungMinu