Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stream: fix finished writable/readable state #31527

Closed
wants to merge 2 commits into from

Conversation

ronag
Copy link
Member

@ronag ronag commented Jan 26, 2020

writable/readable does not indicate whether as stream is
a Writable/Readable. This implements a better check for
whether a object is a Writable/Readable.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

writable/readable does not indicate whether as stream is
a Writable/Readable. This implements a better check for
whether a object is a Writable/Readable.
@ronag
Copy link
Member Author

ronag commented Jan 26, 2020

Might be semver-major?

@mcollina
Copy link
Member

why should it be semver-major?

@ronag
Copy link
Member Author

ronag commented Jan 26, 2020

It can give ERR_STREAM_PREMATURE_CLOSE in cases where it didn't before. Though that's probably a bug fix.

@mcollina mcollina added the baking-for-lts PRs that need to wait before landing in a LTS release. label Jan 26, 2020
@mcollina
Copy link
Member

What happen in the given case in master?

@ronag
Copy link
Member Author

ronag commented Jan 26, 2020

What happen in the given case in master?

It won't call the callback at all... good call. Bug fix?

@ronag ronag added the stream Issues and PRs related to the stream subsystem. label Jan 26, 2020
@mcollina
Copy link
Member

I’ll go with a patch, with a long backing for lts backport

@nodejs-github-bot
Copy link
Collaborator

@ronag ronag added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jan 27, 2020
@ronag
Copy link
Member Author

ronag commented Jan 27, 2020

@mcollina: approves?

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nodejs-github-bot
Copy link
Collaborator

@Trott
Copy link
Member

Trott commented Jan 29, 2020

Landed in b851d7b

@Trott Trott closed this Jan 29, 2020
Trott pushed a commit to Trott/io.js that referenced this pull request Jan 29, 2020
writable/readable does not indicate whether as stream is
a Writable/Readable. This implements a better check for
whether a object is a Writable/Readable.

PR-URL: nodejs#31527
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Minwoo Jung <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
codebytere pushed a commit that referenced this pull request Feb 17, 2020
writable/readable does not indicate whether as stream is
a Writable/Readable. This implements a better check for
whether a object is a Writable/Readable.

PR-URL: #31527
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Minwoo Jung <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
@codebytere codebytere mentioned this pull request Feb 17, 2020
@targos targos added backport-blocked-v12.x and removed author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels Apr 25, 2020
@codebytere codebytere mentioned this pull request Nov 2, 2020
3 tasks
@targos targos removed the baking-for-lts PRs that need to wait before landing in a LTS release. label Sep 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stream Issues and PRs related to the stream subsystem.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants