Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: fix test-heapdump-worker #31494

Closed
wants to merge 1 commit into from
Closed

test: fix test-heapdump-worker #31494

wants to merge 1 commit into from

Conversation

addaleax
Copy link
Member

This test was broken by de2c68c.

Refs: #31386

/cc @Trott

Also, this fix is almost identical to ed60e86 … maybe we should have at least one platform/job running the full test suite in CI?

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@addaleax
test: fix test-heapdump-worker
3f15e30 
This test was broken by de2c68c.

Refs: nodejs#31386
@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Jan 24, 2020
@addaleax addaleax added the fast-track PRs that do not need to wait for 48 hours to land. label Jan 24, 2020
@addaleax
Copy link
Member Author

👍 this comment to approve fast-tracking

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/28606/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/28608/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/28611/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/28614/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/28648/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/28653/

@Trott
Copy link
Member

Trott commented Jan 25, 2020

Landed in 278d37d

@Trott Trott closed this Jan 25, 2020
Trott pushed a commit that referenced this pull request Jan 25, 2020
@addaleax @Trott
test: fix test-heapdump-worker
278d37d 
This test was broken by de2c68c.

Refs: #31386

PR-URL: #31494
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: David Carlier <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
codebytere pushed a commit that referenced this pull request Feb 17, 2020
@addaleax @codebytere
test: fix test-heapdump-worker
f2dc694 
This test was broken by de2c68c.

Refs: #31386

PR-URL: #31494
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: David Carlier <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
@codebytere codebytere mentioned this pull request Feb 17, 2020
Merged
codebytere pushed a commit that referenced this pull request Mar 15, 2020
@addaleax @codebytere
test: fix test-heapdump-worker
31e1af6 
This test was broken by de2c68c.

Refs: #31386

PR-URL: #31494
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: David Carlier <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
@addaleax addaleax deleted the pummel-heapdump-worker2 branch March 16, 2020 11:29
codebytere pushed a commit that referenced this pull request Mar 17, 2020
@addaleax @codebytere
test: fix test-heapdump-worker
e3e056d 
This test was broken by de2c68c.

Refs: #31386

PR-URL: #31494
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: David Carlier <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
@codebytere codebytere mentioned this pull request Mar 17, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richardlau richardlau richardlau approved these changes

@devnexen devnexen devnexen approved these changes

@cjihrig cjihrig cjihrig approved these changes

@Trott Trott Trott approved these changes

Assignees
No one assigned
Labels
fast-track PRs that do not need to wait for 48 hours to land. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@addaleax @nodejs-github-bot @Trott @cjihrig @devnexen @richardlau