Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add explanation bit to path.resolve description #31430

Closed
wants to merge 1 commit into from
Closed

add explanation bit to path.resolve description #31430

wants to merge 1 commit into from

Conversation

YakovL
Copy link
Contributor

@YakovL YakovL commented Jan 20, 2020

see #25542 for details

Checklist

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. path Issues and PRs related to the path subsystem. labels Jan 20, 2020
@YakovL
Copy link
Contributor Author

YakovL commented Jan 22, 2020

Can somebody clarify how many approvals are required for this to get merged? :)

@Trott
Copy link
Member

Trott commented Jan 23, 2020 •
edited
Loading

Can somebody clarify how many approvals are required for this to get merged? :)

Two, but that's not the only requirement. Needs to be open for 48 hours and have a passing CI. https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#respect-the-minimum-wait-time-for-comments

@Trott
Copy link
Member

Trott commented Jan 23, 2020

Landed in 4e3dee4.

Thanks for the contribution! 🎉

@Trott Trott closed this Jan 23, 2020
Trott pushed a commit to Trott/io.js that referenced this pull request Jan 23, 2020
@YakovL @Trott
doc: add explanatory to path.resolve description
4e3dee4 
Fixes: nodejs#25542

PR-URL: nodejs#31430
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: David Carlier <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
@YakovL YakovL deleted the patch-1 branch January 23, 2020 08:11
codebytere pushed a commit that referenced this pull request Feb 17, 2020
@YakovL @codebytere
doc: add explanatory to path.resolve description
67d8967 
Fixes: #25542

PR-URL: #31430
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: David Carlier <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
@codebytere codebytere mentioned this pull request Feb 17, 2020
Merged
codebytere pushed a commit that referenced this pull request Mar 15, 2020
@YakovL @codebytere
doc: add explanatory to path.resolve description
b8ebb9c 
Fixes: #25542

PR-URL: #31430
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: David Carlier <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
codebytere pushed a commit that referenced this pull request Mar 17, 2020
@YakovL @codebytere
doc: add explanatory to path.resolve description
11dbdcb 
Fixes: #25542

PR-URL: #31430
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: David Carlier <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
@codebytere codebytere mentioned this pull request Mar 17, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devnexen devnexen devnexen approved these changes

@cjihrig cjihrig cjihrig approved these changes

@addaleax addaleax addaleax approved these changes

@Trott Trott Trott approved these changes

Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations. path Issues and PRs related to the path subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@YakovL @Trott @addaleax @cjihrig @devnexen @nodejs-github-bot