Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

errors: make use of "cannot" consistent #31420

Closed
wants to merge 1 commit into from
Closed

errors: make use of "cannot" consistent #31420

wants to merge 1 commit into from

Conversation

tniessen
Copy link
Member

We frequently use the word "cannot" in error messages, this is the only occurrence of "can not". I am not a native English speaker, but according to various resources, the former should generally be preferred over the latter, and is probably what native speakers would expect.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@tniessen tniessen added doc Issues and PRs related to the documentations. errors Issues and PRs related to JavaScript errors originated in Node.js core. labels Jan 20, 2020
@tniessen
Copy link
Member Author

Not sure if error message changes are semver-minor or not...?

@cjihrig
Copy link
Contributor

cjihrig commented Jan 20, 2020

Not sure if error message changes are semver-minor or not...?

As long as the error code doesn't change, the current policy is for error message changes to be semver patch.

@nodejs-github-bot

This comment has been minimized.

Sign in to view
@tniessen
Copy link
Member Author

Only failures are infrastructure failures.

@tniessen tniessen added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jan 20, 2020
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/28520/

@tniessen tniessen force-pushed the errors-make-cannot-consistent branch from b5d9f15 to a19b777 Compare January 22, 2020 19:51
@tniessen
Copy link
Member Author

Had to rebase and adapt a test case that was added yesterday (#31178).

@nodejs-github-bot

This comment has been minimized.

Sign in to view
mhdawson
mhdawson approved these changes Jan 22, 2020
View reviewed changes
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/28575/

tniessen added a commit that referenced this pull request Jan 23, 2020
@tniessen
errors: make use of "cannot" consistent
9f22fda 
PR-URL: #31420
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Sam Roberts <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
@tniessen
Copy link
Member Author

Landed in 9f22fda, thanks for reviewing!

@tniessen tniessen closed this Jan 23, 2020
@tniessen tniessen deleted the errors-make-cannot-consistent branch January 23, 2020 03:44
codebytere pushed a commit that referenced this pull request Feb 17, 2020
@tniessen @codebytere
errors: make use of "cannot" consistent
e46cfaf 
PR-URL: #31420
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Sam Roberts <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
@codebytere codebytere mentioned this pull request Feb 17, 2020
Merged
codebytere pushed a commit that referenced this pull request Mar 15, 2020
@tniessen @codebytere
errors: make use of "cannot" consistent
dcace84 
PR-URL: #31420
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Sam Roberts <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
codebytere pushed a commit that referenced this pull request Mar 17, 2020
@tniessen @codebytere
errors: make use of "cannot" consistent
b1517a4 
PR-URL: #31420
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Sam Roberts <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
@codebytere codebytere mentioned this pull request Mar 17, 2020
Merged
@tniessen tniessen removed the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jan 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhdawson mhdawson mhdawson approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

@cjihrig cjihrig cjihrig approved these changes

@targos targos targos approved these changes

@addaleax addaleax addaleax approved these changes

@Trott Trott Trott approved these changes

@sam-github sam-github sam-github approved these changes

Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations. errors Issues and PRs related to JavaScript errors originated in Node.js core.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@tniessen @cjihrig @nodejs-github-bot @sam-github @Trott @addaleax @targos @BridgeAR @mhdawson