Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tools: update ESLint to 7.0.0-alpha.2 #31400

Closed
wants to merge 5 commits into from
Closed

Conversation

cjihrig
Copy link
Contributor

@cjihrig cjihrig commented Jan 17, 2020

Update ESLint to 7.0.0-alpha.2

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the tools Issues and PRs related to the tools directory. label Jan 17, 2020
@Trott
Copy link
Member

Trott commented Jan 17, 2020

Is the idea that this won't land until 7.0.0 is out and the PR will be updated to include that?

@cjihrig
Copy link
Contributor Author

cjihrig commented Jan 17, 2020

Is the idea that this won't land until 7.0.0 is out and the PR will be updated to include that?

I'm fine with that approach. FWIW, in the past, we have updated to ESLint alpha releases as well.

Copy link
Member

@BridgeAR BridgeAR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM

Landing the updates incrementally allows us to adjust everything during the individual release and we could already use the changed features. The eslints changes are normally very stable, no matter that it's an alpha. I am fine with waiting or landing it right away therefore.

@BridgeAR BridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jan 20, 2020
Copy link
Member

@trivikr trivikr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM

@cjihrig cjihrig changed the title tools: update ESLint to 7.0.0-alpha.0 tools: update ESLint to 7.0.0-alpha.1 Feb 15, 2020
@cjihrig cjihrig changed the title tools: update ESLint to 7.0.0-alpha.1 tools: update ESLint to 7.0.0-alpha.2 Feb 28, 2020
@nodejs-github-bot

This comment has been minimized.

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Mar 9, 2020

addaleax pushed a commit that referenced this pull request Mar 11, 2020
Update ESLint to 7.0.0-alpha.0

PR-URL: #31400
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
addaleax pushed a commit that referenced this pull request Mar 11, 2020
Update ESLint to 7.0.0-alpha.1

PR-URL: #31400
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
@addaleax
Copy link
Member

Landed in 61f28fb...4f87b4f

addaleax pushed a commit that referenced this pull request Mar 11, 2020
Update ESLint to 7.0.0-alpha.2

PR-URL: #31400
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
addaleax pushed a commit that referenced this pull request Mar 11, 2020
PR-URL: #31400
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
@addaleax addaleax closed this Mar 11, 2020
addaleax pushed a commit that referenced this pull request Mar 11, 2020
PR-URL: #31400
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
@cjihrig cjihrig deleted the eslint branch March 11, 2020 16:02
MylesBorins pushed a commit that referenced this pull request Mar 11, 2020
Update ESLint to 7.0.0-alpha.0

PR-URL: #31400
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
MylesBorins pushed a commit that referenced this pull request Mar 11, 2020
Update ESLint to 7.0.0-alpha.1

PR-URL: #31400
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
MylesBorins pushed a commit that referenced this pull request Mar 11, 2020
Update ESLint to 7.0.0-alpha.2

PR-URL: #31400
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
MylesBorins pushed a commit that referenced this pull request Mar 11, 2020
PR-URL: #31400
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
MylesBorins pushed a commit that referenced this pull request Mar 11, 2020
PR-URL: #31400
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Mar 12, 2020
targos pushed a commit that referenced this pull request Apr 22, 2020
Update ESLint to 7.0.0-alpha.0

PR-URL: #31400
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
targos pushed a commit that referenced this pull request Apr 22, 2020
Update ESLint to 7.0.0-alpha.1

PR-URL: #31400
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
targos pushed a commit that referenced this pull request Apr 22, 2020
Update ESLint to 7.0.0-alpha.2

PR-URL: #31400
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
targos pushed a commit that referenced this pull request Apr 22, 2020
PR-URL: #31400
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
targos pushed a commit that referenced this pull request Apr 22, 2020
PR-URL: #31400
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. tools Issues and PRs related to the tools directory.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants