test: update postmortem test with v12 constants #31391
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmarchini
force-pushed
the
v12-postmortem-tests
branch
from
cf6eeb7
to
a5043ca
Compare
This comment has been minimized.
This comment has been minimized.
cjihrig
approved these changes
Jan 16, 2020
lpinca
approved these changes
Jan 17, 2020
Trott
reviewed
Jan 18, 2020
| @@ -48,7 +48,8 @@ const missing = getExpectedSymbols().filter((symbol) => { | |||
| return !symbols.includes(symbol); | |||
| }); | |||
|
|
|||
| assert.strictEqual(missing.length, 0, `Missing constants: ${missing}`); | |||
| assert.strictEqual(missing.length, 0, | |||
| `Missing constants: \n${missing.join('\n')}`); | |||
There was a problem hiding this comment.
Optional nit suggestion to get rid of a trailing space and indent the missing constants by 2 spaces in the output for easier reading:
Suggested change
| `Missing constants: \n${missing.join('\n')}`); | |
| `Missing constants:\n ${missing.join('\n ')}`); |
Trott
approved these changes
Jan 18, 2020
Trott
added
the
author ready
|
Landed in b318926 |
Trott
pushed a commit
that referenced
this pull request
Jan 18, 2020
Ref: nodejs/llnode#330 PR-URL: #31391 Refs: nodejs/llnode#330 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Rich Trott <[email protected]>
codebytere
pushed a commit
that referenced
this pull request
Feb 17, 2020
Ref: nodejs/llnode#330 PR-URL: #31391 Refs: nodejs/llnode#330 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Rich Trott <[email protected]>
Merged
codebytere
pushed a commit
that referenced
this pull request
Mar 14, 2020
Ref: nodejs/llnode#330 PR-URL: #31391 Refs: nodejs/llnode#330 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Rich Trott <[email protected]>
codebytere
pushed a commit
that referenced
this pull request
Mar 17, 2020
Ref: nodejs/llnode#330 PR-URL: #31391 Refs: nodejs/llnode#330 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Rich Trott <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: nodejs/llnode#330
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes