doc: explain hex encoding in Buffer API
#31352
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixes: nodejs#29786 refs: nodejs#29792 refs: nodejs#24491
nodejs-github-bot
added
buffer
addaleax
reviewed
Jan 14, 2020
addaleax
approved these changes
Jan 16, 2020
Trott
reviewed
Jan 16, 2020
doc/api/buffer.md
Outdated
| // Prints <Buffer 1a>, data truncated when data ends in single digit ('7'). | ||
|
|
||
| Buffer.from('1634', 'hex'); | ||
| // Prints <Buffer 16 34>, fully qualified hexadecimal data |
There was a problem hiding this comment.
Optional nit: Saying that the data was not truncated might be easier to understand than describing it as fully-qualified.
Suggested change
| // Prints <Buffer 16 34>, fully qualified hexadecimal data | |
| // Prints <Buffer 16 34>, all data represented. |
There was a problem hiding this comment.
@Trott, thanks. Fixed it.
Trott
reviewed
Jan 16, 2020
doc/api/buffer.md
Outdated
| ```js | ||
| Buffer.from('1ag', 'hex'); | ||
| // Prints <Buffer 1a>, data truncated when first non-hexadecimal value | ||
| // ('g') encountered |
There was a problem hiding this comment.
Suggested change
| // ('g') encountered | |
| // ('g') encountered. |
Trott
approved these changes
Jan 16, 2020
|
Landed in e43ee37 |
Trott
pushed a commit
that referenced
this pull request
Jan 17, 2020
fixes: #29786 refs: #29792 refs: #24491 PR-URL: #31352 Fixes: #29786 Refs: #29792 Refs: #24491 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Rich Trott <[email protected]>
codebytere
pushed a commit
that referenced
this pull request
Feb 17, 2020
fixes: #29786 refs: #29792 refs: #24491 PR-URL: #31352 Fixes: #29786 Refs: #29792 Refs: #24491 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Rich Trott <[email protected]>
Merged
codebytere
pushed a commit
that referenced
this pull request
Mar 14, 2020
fixes: #29786 refs: #29792 refs: #24491 PR-URL: #31352 Fixes: #29786 Refs: #29792 Refs: #24491 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Rich Trott <[email protected]>
codebytere
pushed a commit
that referenced
this pull request
Mar 17, 2020
fixes: #29786 refs: #29792 refs: #24491 PR-URL: #31352 Fixes: #29786 Refs: #29792 Refs: #24491 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Rich Trott <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #29786
refs: #29792
refs: #24491
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes