Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: add missing code formatting in vm.md #31350

Merged
merged 1 commit into from
Jan 15, 2020
Merged

doc: add missing code formatting in vm.md #31350

merged 1 commit into from
Jan 15, 2020

Conversation

cjihrig
Copy link
Contributor

@cjihrig cjihrig commented Jan 14, 2020

This commit adds missing code formatting in a few places in
the vm module documentation.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

👍 here if you're OK with fast tracking this.

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. vm Issues and PRs related to the vm subsystem. labels Jan 14, 2020
@BridgeAR BridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jan 14, 2020
@cjihrig
doc: add missing code formatting in vm.md
b4f5c9e 
This commit adds missing code formatting in a few places in
the vm module documentation.

PR-URL: nodejs#31350
Reviewed-By: Gus Caplan <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@cjihrig cjihrig added the fast-track PRs that do not need to wait for 48 hours to land. label Jan 15, 2020
@cjihrig cjihrig merged commit b4f5c9e into nodejs:master Jan 15, 2020
@cjihrig cjihrig deleted the docs branch January 15, 2020 14:44
MylesBorins pushed a commit that referenced this pull request Jan 16, 2020
@cjihrig @MylesBorins
doc: add missing code formatting in vm.md
aed00d7 
This commit adds missing code formatting in a few places in
the vm module documentation.

PR-URL: #31350
Reviewed-By: Gus Caplan <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@codebytere codebytere mentioned this pull request Jan 16, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trivikr trivikr trivikr approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

@devsnek devsnek devsnek approved these changes

@lpinca lpinca lpinca approved these changes

@Trott Trott Trott approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land. vm Issues and PRs related to the vm subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@cjihrig @Trott @lpinca @devsnek @BridgeAR @trivikr @codebytere @nodejs-github-bot