Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minor vcbuild.bat fixups #31338

Merged
merged 2 commits into from
Jan 15, 2020
Merged

minor vcbuild.bat fixups #31338

merged 2 commits into from
Jan 15, 2020

Conversation

richardlau
Copy link
Member

The first commit adds the vs2019 option (added by #28781) to the help output.

The second commit removes the enable-vtune option which was removed from configure.py in #28522 and results in a no such option error from configure if used.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to build files or the CI. windows Issues and PRs related to the Windows platform. labels Jan 13, 2020
@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jan 13, 2020

@richardlau richardlau added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jan 13, 2020
PR-URL: nodejs#31338
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
vcbuild.bat wasn't updated when vtune support was removed in
nodejs#28522

Refs: nodejs#28522
PR-URL: nodejs#31338
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
@richardlau richardlau self-assigned this Jan 15, 2020
@richardlau richardlau merged commit e67dc1e into nodejs:master Jan 15, 2020
@richardlau
Copy link
Member Author

Landed in dcbf9da...e67dc1e

MylesBorins pushed a commit that referenced this pull request Jan 16, 2020
PR-URL: #31338
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
MylesBorins pushed a commit that referenced this pull request Jan 16, 2020
vcbuild.bat wasn't updated when vtune support was removed in
#28522

Refs: #28522
PR-URL: #31338
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
@codebytere codebytere mentioned this pull request Jan 16, 2020
codebytere pushed a commit that referenced this pull request Mar 14, 2020
PR-URL: #31338
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
codebytere pushed a commit that referenced this pull request Mar 14, 2020
vcbuild.bat wasn't updated when vtune support was removed in
#28522

Refs: #28522
PR-URL: #31338
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
codebytere pushed a commit that referenced this pull request Mar 17, 2020
PR-URL: #31338
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
codebytere pushed a commit that referenced this pull request Mar 17, 2020
vcbuild.bat wasn't updated when vtune support was removed in
#28522

Refs: #28522
PR-URL: #31338
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
@codebytere codebytere mentioned this pull request Mar 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. build Issues and PRs related to build files or the CI. windows Issues and PRs related to the Windows platform.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants