[v13.x] deps: deactivate failing tests corresponding to experimental features #31289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
v13.x
v8 engine
richardlau
reviewed
Jan 9, 2020
addaleax
changed the title
addaleax
approved these changes
Jan 10, 2020
BridgeAR
force-pushed
the
2020-01-09-deactivate-failing-tests
branch
from
37fb1ca
to
79113ae
Compare
targos
approved these changes
Jan 10, 2020
This comments out three tests that consistently fail on v13.x. The test can be activated again in case the necessary code change lands on v13.x for the tests to pass.
BridgeAR
force-pushed
the
2020-01-09-deactivate-failing-tests
branch
from
79113ae
to
4ce0365
Compare
|
@richardlau the tests seem to be executed even though I used I therefore went back to commenting them out. |
BridgeAR
added
the
author ready
richardlau
approved these changes
Jan 11, 2020
Trott
pushed a commit
that referenced
this pull request
Jan 11, 2020
This comments out three tests that consistently fail on v13.x. The test can be activated again in case the necessary code change lands on v13.x for the tests to pass. PR-URL: #31289 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Richard Lau <[email protected]>
|
Landed in 6f95f01 |
Merged
|
@BridgeAR should this go to v12.x? It doesn't land cleanly but also may be a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This comments out three tests that consistently fail on v13.x.
The test can be activated again in case the necessary code change
lands on v13.x for the tests to pass.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes