Release proposal: v4.1.2

CHANGELOG.md

@@ -1,5 +1,46 @@
 # Node.js ChangeLog
 
+## 2015-10-05, Version 4.1.2 (Stable), @rvagg
+
+### Notable changes
+
+_WIP_
+
+### Known issues
+
+See https://github.com/nodejs/node/labels/confirmed-bug for complete and current list of known issues.
+
+* Some problems with unreferenced timers running during `beforeExit` are still to be resolved. See [#1264](https://github.com/nodejs/node/issues/1264).
+* Surrogate pair in REPL can freeze terminal. [#690](https://github.com/nodejs/node/issues/690)
+* Calling `dns.setServers()` while a DNS query is in progress can cause the process to crash on a failed assertion. [#894](https://github.com/nodejs/node/issues/894)
+* `url.resolve` may transfer the auth portion of the url when resolving between two full hosts, see [#1435](https://github.com/nodejs/node/issues/1435).
+
+### Commits
+
+* [[`3de58b9531`](https://github.com/nodejs/node/commit/3de58b9531)] - **benchmark**: update comment in common.js (Minwoo Jung) [#2399](https://github.com/nodejs/node/pull/2399)
+* [[`9e9bfa4dc0`](https://github.com/nodejs/node/commit/9e9bfa4dc0)] - **build**: iojs -> nodejs of release-urlbase (P.S.V.R) [#3015](https://github.com/nodejs/node/pull/3015)
+* [[`8335ec7191`](https://github.com/nodejs/node/commit/8335ec7191)] - **build**: fix some typos inside the configure script (P.S.V.R) [#3016](https://github.com/nodejs/node/pull/3016)
+* [[`798dad24f4`](https://github.com/nodejs/node/commit/798dad24f4)] - **child_process**: `null` channel handle on close (Fedor Indutny) [#3041](https://github.com/nodejs/node/pull/3041)
+* [[`4c8d96bc30`](https://github.com/nodejs/node/commit/4c8d96bc30)] - **crypto**: add more keylen sanity checks in pbkdf2 (Johann) [#3029](https://github.com/nodejs/node/pull/3029)
+* [[`039f73fa83`](https://github.com/nodejs/node/commit/039f73fa83)] - **deps**: remove and gitignore .bin directory (Ben Noordhuis) [#3004](https://github.com/nodejs/node/pull/3004)
+* [[`5fbb24812d`](https://github.com/nodejs/node/commit/5fbb24812d)] - **deps**: backport c281c15 from V8's upstream (Julien Gilli) [#3031](https://github.com/nodejs/node/pull/3031)
+* [[`55a1f94e44`](https://github.com/nodejs/node/commit/55a1f94e44)] - **dns**: remove nonexistant exports.ADNAME (Roman Reiss) [#3051](https://github.com/nodejs/node/pull/3051)
+* [[`6ee5d0f69f`](https://github.com/nodejs/node/commit/6ee5d0f69f)] - **dns**: add missing exports.BADNAME (Roman Reiss) [#3051](https://github.com/nodejs/node/pull/3051)
+* [[`75d5dcea76`](https://github.com/nodejs/node/commit/75d5dcea76)] - **doc**: jenkins-iojs.nodesource.com -> ci.nodejs.org (Michał Gołębiowski) [#2886](https://github.com/nodejs/node/pull/2886)
+* [[`5c3f50b21d`](https://github.com/nodejs/node/commit/5c3f50b21d)] - **doc**: rearrange execSync and execFileSync (Laurent Fortin) [#2940](https://github.com/nodejs/node/pull/2940)
+* [[`4fc33ac11a`](https://github.com/nodejs/node/commit/4fc33ac11a)] - **doc**: make execFileSync in line with execFile (Laurent Fortin) [#2940](https://github.com/nodejs/node/pull/2940)
+* [[`a366e84b17`](https://github.com/nodejs/node/commit/a366e84b17)] - **doc**: fix typos in cluster & errors (reggi) [#3011](https://github.com/nodejs/node/pull/3011)
+* [[`52031e1bf1`](https://github.com/nodejs/node/commit/52031e1bf1)] - **doc**: switch LICENSE from closure-linter to eslint (P.S.V.R) [#3018](https://github.com/nodejs/node/pull/3018)
+* [[`b28f6a53bc`](https://github.com/nodejs/node/commit/b28f6a53bc)] - **docs**: Clarify assert.doesNotThrow behavior (Fabio Oliveira) [#2807](https://github.com/nodejs/node/pull/2807)
+* [[`ac2bce0b0c`](https://github.com/nodejs/node/commit/ac2bce0b0c)] - **path**: improve posixSplitPath performance (Evan Lucas) [#3034](https://github.com/nodejs/node/pull/3034)
+* [[`4fc89939f5`](https://github.com/nodejs/node/commit/4fc89939f5)] - **smalloc**: remove module (Brendan Ashworth) [#3099](https://github.com/nodejs/node/pull/3099)
+* [[`5ec5d0aa8b`](https://github.com/nodejs/node/commit/5ec5d0aa8b)] - **src**: internalize binding function property names (Ben Noordhuis) [#3060](https://github.com/nodejs/node/pull/3060)
+* [[`c8175fc2af`](https://github.com/nodejs/node/commit/c8175fc2af)] - **src**: internalize per-isolate string properties (Ben Noordhuis) [#3060](https://github.com/nodejs/node/pull/3060)
+* [[`9a593abc47`](https://github.com/nodejs/node/commit/9a593abc47)] - **src**: include signal.h in util.h (Cheng Zhao) [#3058](https://github.com/nodejs/node/pull/3058)
+* [[`fde0c6f321`](https://github.com/nodejs/node/commit/fde0c6f321)] - **src**: fix function and variable names in comments (Sakthipriyan Vairamani) [#3039](https://github.com/nodejs/node/pull/3039)
+* [[`1e964bb8e9`](https://github.com/nodejs/node/commit/1e964bb8e9)] - **test**: change calls to deprecated util.print() (Rich Trott) [#3083](https://github.com/nodejs/node/pull/3083)
+* [[`b97358a772`](https://github.com/nodejs/node/commit/b97358a772)] - **test**: replace deprecated util.debug() calls (Rich Trott) [#3082](https://github.com/nodejs/node/pull/3082)
+
 ## 2015-09-22, Version 4.1.1 (Stable), @rvagg
 
 ### Notable changes

benchmark/common.js

@@ -137,7 +137,7 @@ Benchmark.prototype._run = function() {
   if (this.config)
     return this.fn(this.config);
 
-  // one more more options weren't set.
+  // some options weren't set.
   // run with all combinations
   var main = require.main.filename;
   var settings = [];

lib/dns.js

@@ -330,7 +330,6 @@ exports.NOTFOUND = 'ENOTFOUND';
 exports.NOTIMP = 'ENOTIMP';
 exports.REFUSED = 'EREFUSED';
 exports.BADQUERY = 'EBADQUERY';
-exports.ADNAME = 'EADNAME';
 exports.BADNAME = 'EBADNAME';
 exports.BADFAMILY = 'EBADFAMILY';
 exports.BADRESP = 'EBADRESP';

src/node_version.h

@@ -5,7 +5,7 @@
 #define NODE_MINOR_VERSION 1
 #define NODE_PATCH_VERSION 2
 
-#define NODE_VERSION_IS_RELEASE 0
+#define NODE_VERSION_IS_RELEASE 1
 
 #ifndef NODE_STRINGIFY
 #define NODE_STRINGIFY(n) NODE_STRINGIFY_HELPER(n)

test/disabled/test-sendfd.js

@@ -52,7 +52,7 @@ var logChild = function(d) {
 
   d.split('\n').forEach(function(l) {
     if (l.length > 0) {
-      common.debug('CHILD: ' + l);
+      console.error('CHILD: ' + l);
     }
   });
 };

test/fixtures/net-fd-passing-receiver.js

@@ -26,7 +26,7 @@ receiver = net.createServer(function(socket) {
 
 /* To signal the test runne we're up and listening */
 receiver.on('listening', function() {
-  common.print('ready');
+  console.log('ready');
 });
 
 receiver.listen(path);

test/parallel/test-file-read-noexist.js

@@ -10,8 +10,8 @@ fs.readFile(filename, 'raw', function(err, content) {
   if (err) {
     got_error = true;
   } else {
-    common.debug('cat returned some content: ' + content);
-    common.debug('this shouldn\'t happen as the file doesn\'t exist...');
+    console.error('cat returned some content: ' + content);
+    console.error('this shouldn\'t happen as the file doesn\'t exist...');
     assert.equal(true, false);
   }
 });

test/parallel/test-fs-realpath.js

@@ -326,7 +326,6 @@ function test_deep_symlink_mix(callback) {
       [fixturesAbsDir + '/nested-index/two/realpath-c',
         '../../../' + common.tmpDirName + '/cycles/root.js']
     ].forEach(function(t) {
-      //common.debug('setting up '+t[0]+' -> '+t[1]);
       try { fs.unlinkSync(t[0]); } catch (e) {}
       fs.symlinkSync(t[1], t[0]);
       unlink.push(t[0]);

test/parallel/test-http-after-connect.js

@@ -8,7 +8,7 @@ var serverRequests = 0;
 var clientResponses = 0;
 
 var server = http.createServer(function(req, res) {
-  common.debug('Server got GET request');
+  console.error('Server got GET request');
   req.resume();
   ++serverRequests;
   res.writeHead(200);
@@ -18,7 +18,7 @@ var server = http.createServer(function(req, res) {
   }, 50);
 });
 server.on('connect', function(req, socket, firstBodyChunk) {
-  common.debug('Server got CONNECT request');
+  console.error('Server got CONNECT request');
   serverConnected = true;
   socket.write('HTTP/1.1 200 Connection established\r\n\r\n');
   socket.resume();
@@ -33,7 +33,7 @@ server.listen(common.PORT, function() {
     path: 'google.com:80'
   });
   req.on('connect', function(res, socket, firstBodyChunk) {
-    common.debug('Client got CONNECT response');
+    console.error('Client got CONNECT response');
     socket.end();
     socket.on('end', function() {
       doRequest(0);
@@ -49,7 +49,7 @@ function doRequest(i) {
     port: common.PORT,
     path: '/request' + i
   }, function(res) {
-    common.debug('Client got GET response');
+    console.error('Client got GET response');
     var data = '';
     res.setEncoding('utf8');
     res.on('data', function(chunk) {

test/parallel/test-http-connect.js

@@ -12,7 +12,7 @@ var server = http.createServer(function(req, res) {
 server.on('connect', function(req, socket, firstBodyChunk) {
   assert.equal(req.method, 'CONNECT');
   assert.equal(req.url, 'google.com:443');
-  common.debug('Server got CONNECT request');
+  console.error('Server got CONNECT request');
   serverGotConnect = true;
 
   socket.write('HTTP/1.1 200 Connection established\r\n\r\n');
@@ -40,7 +40,7 @@ server.listen(common.PORT, function() {
   });
 
   req.on('connect', function(res, socket, firstBodyChunk) {
-    common.debug('Client got CONNECT request');
+    console.error('Client got CONNECT request');
     clientGotConnect = true;
 
     // Make sure this request got removed from the pool.

test/parallel/test-http-expect-continue.js

@@ -11,7 +11,7 @@ var got_continue = false;
 
 function handler(req, res) {
   assert.equal(sent_continue, true, 'Full response sent before 100 Continue');
-  common.debug('Server sending full response...');
+  console.error('Server sending full response...');
   res.writeHead(200, {
     'Content-Type' : 'text/plain',
     'ABCD' : '1'
@@ -21,7 +21,7 @@ function handler(req, res) {
 
 var server = http.createServer(handler);
 server.on('checkContinue', function(req, res) {
-  common.debug('Server got Expect: 100-continue...');
+  console.error('Server got Expect: 100-continue...');
   res.writeContinue();
   sent_continue = true;
   setTimeout(function() {
@@ -38,11 +38,11 @@ server.on('listening', function() {
     path: '/world',
     headers: { 'Expect': '100-continue' }
   });
-  common.debug('Client sending request...');
+  console.error('Client sending request...');
   outstanding_reqs++;
   var body = '';
   req.on('continue', function() {
-    common.debug('Client got 100 Continue...');
+    console.error('Client got 100 Continue...');
     got_continue = true;
     req.end(test_req_body);
   });
@@ -54,7 +54,7 @@ server.on('listening', function() {
     res.setEncoding('utf8');
     res.on('data', function(chunk) { body += chunk; });
     res.on('end', function() {
-      common.debug('Got full response.');
+      console.error('Got full response.');
       assert.equal(body, test_res_body, 'Response body doesn\'t match.');
       assert.ok('abcd' in res.headers, 'Response headers missing.');
       outstanding_reqs--;

test/parallel/test-http-legacy.js

@@ -54,7 +54,7 @@ server.listen(common.PORT, function() {
     responses_recvd += 1;
     res.setEncoding('utf8');
     res.on('data', function(chunk) { body0 += chunk; });
-    common.debug('Got /hello response');
+    console.error('Got /hello response');
   });
 
   setTimeout(function() {
@@ -65,16 +65,16 @@ server.listen(common.PORT, function() {
       responses_recvd += 1;
       res.setEncoding('utf8');
       res.on('data', function(chunk) { body1 += chunk; });
-      common.debug('Got /world response');
+      console.error('Got /world response');
     });
   }, 1);
 });
 
 process.on('exit', function() {
-  common.debug('responses_recvd: ' + responses_recvd);
+  console.error('responses_recvd: ' + responses_recvd);
   assert.equal(2, responses_recvd);
 
-  common.debug('responses_sent: ' + responses_sent);
+  console.error('responses_sent: ' + responses_sent);
   assert.equal(2, responses_sent);
 
   assert.equal('The path was /hello', body0);

test/parallel/test-http-pause.js

@@ -9,17 +9,17 @@ var expectedClient = 'Response Body from Server';
 var resultClient = '';
 
 var server = http.createServer(function(req, res) {
-  common.debug('pause server request');
+  console.error('pause server request');
   req.pause();
   setTimeout(function() {
-    common.debug('resume server request');
+    console.error('resume server request');
     req.resume();
     req.setEncoding('utf8');
     req.on('data', function(chunk) {
       resultServer += chunk;
     });
     req.on('end', function() {
-      common.debug(resultServer);
+      console.error(resultServer);
       res.writeHead(200);
       res.end(expectedClient);
     });
@@ -32,16 +32,16 @@ server.listen(common.PORT, function() {
     path: '/',
     method: 'POST'
   }, function(res) {
-    common.debug('pause client response');
+    console.error('pause client response');
     res.pause();
     setTimeout(function() {
-      common.debug('resume client response');
+      console.error('resume client response');
       res.resume();
       res.on('data', function(chunk) {
         resultClient += chunk;
       });
       res.on('end', function() {
-        common.debug(resultClient);
+        console.error(resultClient);
         server.close();
       });
     }, 100);

test/parallel/test-http-pipe-fs.js

@@ -31,15 +31,15 @@ var server = http.createServer(function(req, res) {
         }
       }, function(res) {
         res.on('end', function() {
-          common.debug('res' + i + ' end');
+          console.error('res' + i + ' end');
           if (i === 2) {
             server.close();
           }
         });
         res.resume();
       });
       req.on('socket', function(s) {
-        common.debug('req' + i + ' start');
+        console.error('req' + i + ' start');
       });
       req.end('12345');
     }(i + 1));

test/parallel/test-http-set-timeout.js

@@ -10,7 +10,7 @@ var server = http.createServer(function(req, res) {
   assert.ok(s instanceof net.Socket);
   req.connection.on('timeout', function() {
     req.connection.destroy();
-    common.debug('TIMEOUT');
+    console.error('TIMEOUT');
     server.close();
   });
 });

test/parallel/test-http.js

@@ -56,7 +56,7 @@ server.on('listening', function() {
     responses_recvd += 1;
     res.setEncoding('utf8');
     res.on('data', function(chunk) { body0 += chunk; });
-    common.debug('Got /hello response');
+    console.error('Got /hello response');
   });
 
   setTimeout(function() {
@@ -70,17 +70,17 @@ server.on('listening', function() {
       responses_recvd += 1;
       res.setEncoding('utf8');
       res.on('data', function(chunk) { body1 += chunk; });
-      common.debug('Got /world response');
+      console.error('Got /world response');
     });
     req.end();
   }, 1);
 });
 
 process.on('exit', function() {
-  common.debug('responses_recvd: ' + responses_recvd);
+  console.error('responses_recvd: ' + responses_recvd);
   assert.equal(2, responses_recvd);
 
-  common.debug('responses_sent: ' + responses_sent);
+  console.error('responses_sent: ' + responses_sent);
   assert.equal(2, responses_sent);
 
   assert.equal('The path was /hello', body0);

test/parallel/test-https-drain.js

@@ -34,7 +34,7 @@ server.listen(common.PORT, function() {
   }, function(res) {
     var timer;
     res.pause();
-    common.debug('paused');
+    console.error('paused');
     send();
     function send() {
       if (req.write(new Buffer(bufSize))) {
@@ -43,10 +43,10 @@ server.listen(common.PORT, function() {
         return process.nextTick(send);
       }
       sent += bufSize;
-      common.debug('sent: ' + sent);
+      console.error('sent: ' + sent);
       resumed = true;
       res.resume();
-      common.debug('resumed');
+      console.error('resumed');
       timer = setTimeout(function() {
         process.exit(1);
       }, 1000);
@@ -60,7 +60,7 @@ server.listen(common.PORT, function() {
       }
       received += data.length;
       if (received >= sent) {
-        common.debug('received: ' + received);
+        console.error('received: ' + received);
         req.end();
         server.close();
       }

test/parallel/test-module-loading-error.js

@@ -2,7 +2,7 @@
 var common = require('../common');
 var assert = require('assert');
 
-common.debug('load test-module-loading-error.js');
+console.error('load test-module-loading-error.js');
 
 var error_desc = {
   win32: '%1 is not a valid Win32 application',

test/parallel/test-net-listen-close-server.js

@@ -10,7 +10,7 @@ server.listen(common.PORT, function() {
   assert(false);
 });
 server.on('error', function(error) {
-  common.debug(error);
+  console.error(error);
   assert(false);
 });
 server.close();

test/parallel/test-net-listen-error.js

@@ -10,7 +10,7 @@ server.listen(1, '1.1.1.1', function() { // EACCESS or EADDRNOTAVAIL
   assert(false);
 });
 server.on('error', function(error) {
-  common.debug(error);
+  console.error(error);
   gotError = true;
 });