test: remove unused symlink loop #31267
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This symlink loop was originally intended to be accessed from a test. Instead, a loop is created by the test itself, but this was unfortunately forgotten about. It's unused, so remove it.
|
Thanks, @cjihrig |
sam-github
approved these changes
Jan 9, 2020
devnexen
approved these changes
Jan 9, 2020
Trott
approved these changes
Jan 9, 2020
cjihrig
added
the
author ready
addaleax
approved these changes
Jan 9, 2020
addaleax
pushed a commit
that referenced
this pull request
Jan 9, 2020
This symlink loop was originally intended to be accessed from a test. Instead, a loop is created by the test itself, but this was unfortunately forgotten about. It's unused, so remove it. PR-URL: #31267 Reviewed-By: Sam Roberts <[email protected]> Reviewed-By: David Carlier <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
|
Landed in d1d71db |
MylesBorins
pushed a commit
that referenced
this pull request
Jan 16, 2020
This symlink loop was originally intended to be accessed from a test. Instead, a loop is created by the test itself, but this was unfortunately forgotten about. It's unused, so remove it. PR-URL: #31267 Reviewed-By: Sam Roberts <[email protected]> Reviewed-By: David Carlier <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
Merged
codebytere
pushed a commit
that referenced
this pull request
Mar 14, 2020
This symlink loop was originally intended to be accessed from a test. Instead, a loop is created by the test itself, but this was unfortunately forgotten about. It's unused, so remove it. PR-URL: #31267 Reviewed-By: Sam Roberts <[email protected]> Reviewed-By: David Carlier <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This symlink loop was originally intended to be accessed from a test. Instead, a loop is created in the test itself, but this was unfortunately forgotten about. It's unused, so remove it.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes👍 here if you'd like to fast track this.