Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: update README to make Node.js description clearer #31266

Closed
wants to merge 1 commit into from
Closed

doc: update README to make Node.js description clearer #31266

wants to merge 1 commit into from

Conversation

carterbancroft
Copy link
Contributor

Fixes: #24872

This PR updates the README's original description:

Node.js is a JavaScript runtime built on Chrome's V8 JavaScript engine.

To:

Node.js is an open-source, cross-platform, JavaScript runtime environment. It executes JavaScript code outside of a browser

Based on the two sentence suggestion from the issue discussion.

Checklist

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Jan 9, 2020
@BridgeAR BridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jan 9, 2020
@Trott
Copy link
Member

Trott commented Jan 11, 2020

Landed in 6d44308

@Trott Trott closed this Jan 11, 2020
Trott pushed a commit to Trott/io.js that referenced this pull request Jan 11, 2020
@carterbancroft @Trott
doc: update README to make Node.js description clearer
6d44308 
Fixes: nodejs#24872

PR-URL: nodejs#31266
Reviewed-By: David Carlier <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
MylesBorins pushed a commit that referenced this pull request Jan 16, 2020
@carterbancroft @MylesBorins
doc: update README to make Node.js description clearer
deff600 
Fixes: #24872

PR-URL: #31266
Reviewed-By: David Carlier <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
@codebytere codebytere mentioned this pull request Jan 16, 2020
Merged
codebytere pushed a commit that referenced this pull request Mar 14, 2020
@carterbancroft @codebytere
doc: update README to make Node.js description clearer
07c3b6d 
Fixes: #24872

PR-URL: #31266
Reviewed-By: David Carlier <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
codebytere pushed a commit that referenced this pull request Mar 17, 2020
@carterbancroft @codebytere
doc: update README to make Node.js description clearer
cb40a1a 
Fixes: #24872

PR-URL: #31266
Reviewed-By: David Carlier <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
@codebytere codebytere mentioned this pull request Mar 17, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BridgeAR BridgeAR BridgeAR approved these changes

@gireeshpunathil gireeshpunathil gireeshpunathil approved these changes

@devnexen devnexen devnexen approved these changes

@lpinca lpinca lpinca approved these changes

@Trott Trott Trott approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Need change in the read me file
7 participants
@carterbancroft @Trott @lpinca @devnexen @gireeshpunathil @BridgeAR @nodejs-github-bot