Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

win: change to use Python in install tool #31221

Closed
wants to merge 1 commit into from
Closed

win: change to use Python in install tool #31221

wants to merge 1 commit into from

Conversation

gengjiawen
Copy link
Member

@gengjiawen gengjiawen commented Jan 6, 2020 •
edited
Loading

Now our toolchain in Python3 compatible, this need to update.

cc @nodejs/platform-windows

Related: nodejs/node-gyp#1977 (comment).

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added install Issues and PRs related to the installers. tools Issues and PRs related to the tools directory. windows Issues and PRs related to the Windows platform. labels Jan 6, 2020
@gengjiawen gengjiawen mentioned this pull request Jan 6, 2020
Closed
@cclauss cclauss mentioned this pull request Jan 6, 2020
Closed
63 tasks
richardlau
richardlau requested changes Jan 6, 2020
View reviewed changes
Copy link
Member

@richardlau richardlau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The text being changed is in a dialog that, if checked, runs tools/msvs/install_tools/install_tools.bat. This currently installs/updates Python 2 and has corresponding text:

node/tools/msvs/install_tools/install_tools.bat

Line 41 in 20fd123

echo - https://chocolatey.org/packages/python2

node/tools/msvs/install_tools/install_tools.bat

Line 55 in 20fd123

"%SystemRoot%\System32\WindowsPowerShell\v1.0\powershell.exe" -NoProfile -InputFormat None -ExecutionPolicy Bypass -Command Start-Process '%SystemRoot%\System32\WindowsPowerShell\v1.0\powershell.exe' -ArgumentList '-NoProfile -InputFormat None -ExecutionPolicy Bypass -Command iex ((New-Object System.Net.WebClient).DownloadString(''https://chocolatey.org/install.ps1'')); choco upgrade -y python2 visualstudio2017-workload-vctools; Read-Host ''Type ENTER to exit'' ' -Verb RunAs

They should also be changed for consistency.

Trott
Trott approved these changes Jan 8, 2020
View reviewed changes
Copy link
Member

@Trott Trott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I have no way to test this and I don't think it's CI-testable? If a few people can confirm that they tested these changes and it worked for them, that would be good.

@BridgeAR BridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jan 8, 2020
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/28296/

@Trott
Copy link
Member

Trott commented Jan 8, 2020

Landed in 85ef944

Trott pushed a commit that referenced this pull request Jan 8, 2020
@gengjiawen @Trott
win: change to use Python in install tool
85ef944 
PR-URL: #31221
Reviewed-By: David Carlier <[email protected]>
Reviewed-By: Sam Roberts <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Christian Clauss <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
@Trott Trott closed this Jan 8, 2020
@Trott
Copy link
Member

Trott commented Jan 8, 2020

Landed in 85ef944

MylesBorins pushed a commit that referenced this pull request Jan 16, 2020
@gengjiawen @MylesBorins
win: change to use Python in install tool
66fe923 
PR-URL: #31221
Reviewed-By: David Carlier <[email protected]>
Reviewed-By: Sam Roberts <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Christian Clauss <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
@codebytere codebytere mentioned this pull request Jan 16, 2020
Merged
codebytere pushed a commit that referenced this pull request Mar 14, 2020
@gengjiawen @codebytere
win: change to use Python in install tool
2029c10 
PR-URL: #31221
Reviewed-By: David Carlier <[email protected]>
Reviewed-By: Sam Roberts <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Christian Clauss <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
@codebytere codebytere mentioned this pull request Mar 17, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BridgeAR BridgeAR BridgeAR approved these changes

@richardlau richardlau richardlau approved these changes

@devnexen devnexen devnexen approved these changes

@cclauss cclauss cclauss approved these changes

@lpinca lpinca lpinca approved these changes

@Trott Trott Trott approved these changes

@sam-github sam-github sam-github approved these changes

@joaocgreis joaocgreis Awaiting requested review from joaocgreis

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. install Issues and PRs related to the installers. tools Issues and PRs related to the tools directory. windows Issues and PRs related to the Windows platform.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@gengjiawen @nodejs-github-bot @Trott @sam-github @lpinca @cclauss @devnexen @richardlau @BridgeAR